Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add total time to profiler. #278

Merged
merged 3 commits into from
Oct 26, 2019
Merged

Add total time to profiler. #278

merged 3 commits into from
Oct 26, 2019

Conversation

RageZBla
Copy link
Contributor

#223

Q A
Bug fix no
New feature yes
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets #223
License MIT

@RageZBla
Copy link
Contributor Author

I probably need to add few more things if you can point us into the right direction 🙇

@RageZBla
Copy link
Contributor Author

@gregurco @florianpreusner I have updated the markup, here a screenshot

image

Let us know if it's good enough 🙇‍♂️

@gregurco gregurco self-requested a review October 18, 2019 08:39
@gregurco gregurco added this to the v8 milestone Oct 18, 2019
florianpreusner
florianpreusner approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@florianpreusner florianpreusner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gregurco gregurco merged commit 11814ce into 8p:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianpreusner florianpreusner florianpreusner approved these changes

@gregurco gregurco gregurco approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RageZBla @florianpreusner @gregurco