Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Rename subscriber to listener #281

Merged
merged 1 commit into from
Nov 29, 2019
Merged

[Documentation] Rename subscriber to listener #281

merged 1 commit into from
Nov 29, 2019

Conversation

gregurco
Copy link
Member

Q A
Bug fix no
New feature no
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets #279
License MIT

@gregurco gregurco added this to the v8 milestone Nov 28, 2019
florianpreusner
florianpreusner approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@florianpreusner florianpreusner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gregurco gregurco merged commit aad7d6c into 8p:master Nov 29, 2019
@gregurco gregurco deleted the rename_subscriber_to_listener branch November 29, 2019 07:17
@rpkamp rpkamp mentioned this pull request Nov 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianpreusner florianpreusner florianpreusner approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregurco @florianpreusner