Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Add info about upgrading From 7.x to 8.0 #290

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

gregurco
Copy link
Member

@gregurco gregurco commented Jan 6, 2020

Q A
Bug fix no
New feature no
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets -
License MIT

@gregurco gregurco added this to the v8 milestone Jan 6, 2020
@gabfr
Copy link

gabfr commented Jan 6, 2020

Hey @gregurco, what about shifting the PHP version to 7.2 since the 7.1 reached EOL?

@gregurco
Copy link
Member Author

gregurco commented Jan 6, 2020

Hello @gabfr
I know that PHP 7.1 reached EOL, but v8.0 of bundle will support SF 4.0, which requires at least PHP 7.1. From our side there are no reasons to restrict usage of PHP 7.1 - we don't receive any benefits by this restriction, but will cut a part of our users from this upgrade, event if they use SF 4.0.

Do you see any reasons to upgrade to PHP 7.2, besides EOL of this version?

@gabfr
Copy link

gabfr commented Jan 6, 2020

I see, you're right, SF 4.0 requires PHP 7.1. The only reason I had to shift it with some small fixes is because when I upgraded my application to SF 5 I faced some errors regarding the PHP version specification and some interface methods that conflicted the signature with the new version of the SF HttpKernel 5. This may cause some issues also when you start using SF 5 in your app.

Although, I think this can wait until SF 4 reach EOL also.

@gregurco
Copy link
Member Author

gregurco commented Jan 6, 2020

@gabfr great 🙂 please report issues related to integration with SF 5 and we will try to resolve them.

Copy link
Member

@florianpreusner florianpreusner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@gregurco gregurco merged commit a0a4f9f into 8p:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants