Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with HTTP Kernel bundle type hints #298

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Fix compatibility with HTTP Kernel bundle type hints #298

merged 1 commit into from
Feb 27, 2020

Conversation

gregurco
Copy link
Member

Q A
Bug fix yes
New feature no
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets #297
License MIT

Interface should be compatible with types from here: https://github.com/symfony/http-kernel/blob/v5.0.4/Bundle/Bundle.php#L37

@gregurco gregurco added the bug label Feb 26, 2020
florianpreusner
florianpreusner approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@florianpreusner florianpreusner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 thanks!

@gregurco gregurco merged commit 0f0f0f3 into 8p:master Feb 27, 2020
@gregurco gregurco deleted the compatibility_with_http_kernel branch February 27, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianpreusner florianpreusner florianpreusner approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregurco @florianpreusner