-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed guzzle version constraints and avoid old promises function API #328
Conversation
GrahamCampbell
commented
May 23, 2023
•
edited
Loading
edited
Q | A |
---|---|
Bug fix | yes |
New feature | no |
BC breaks | no |
Deprecations | no |
Tests pass | yes |
Fixed tickets | #325 and #327 |
License | MIT |
@@ -27,7 +27,9 @@ | |||
], | |||
"require": { | |||
"php": ">=7.1", | |||
"guzzlehttp/guzzle": "~6.0|~7.0", | |||
"guzzlehttp/guzzle": "^6.5.8|^7.4.5", | |||
"guzzlehttp/promises": "^1.5.3|^2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added because you are implicitly using this dependency, and similarly for psr7.
@@ -27,7 +27,9 @@ | |||
], | |||
"require": { | |||
"php": ">=7.1", | |||
"guzzlehttp/guzzle": "~6.0|~7.0", | |||
"guzzlehttp/guzzle": "^6.5.8|^7.4.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is adjusted to avoid versions with known security vulnerabilities.
Test failures are unrelated. I have sent in a separate PR to fix that other broken test: #329. |
@GrahamCampbell could you please rebase your branch to apply the fix? |
078b34b
to
0e1c972
Compare
CI passing now. |
@GrahamCampbell thank you 👍 |