Using unordered map + making code more readable #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm This PR is very old – is there any plans to merge it? |
|
Hey.. sorry for the delayed response.. @galloj Could you please apply some fix for merge conflicts? Let's merge this soon :) |
|
I assume the merge conflict arises from #39. I could resolve the merge conflict but GitHub says I lack write access? Sorry, I am new to GitHub (I usually use GitLab), tell me if I can help... |
|
Hope I done it correctly, the size of diff scares me. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #16 and make code more readable