Improved code

AArtlone · Oct 16, 2020 · b3a3f51 · b3a3f51
1 parent 8e92b8a
commit b3a3f51
Showing 1 changed file with 11 additions and 18 deletions.
diff --git a/SnowBrawl/Assets/Scripts/ControlsSelection/ControlsSelection.cs b/SnowBrawl/Assets/Scripts/ControlsSelection/ControlsSelection.cs
@@ -102,12 +102,7 @@ private void SaveNewKeyBinding(KeyCode keyCode)
 
         Destroy(controlListenerCanvas);
 
-        KeysSettings keysSettings;
-
-        if (selectedPlayer == PlayerID.P1)
-            keysSettings = p1KeysSettings;
-        else
-            keysSettings = p2KeysSettings;
+        var keysSettings = GetSettingsByID(controlListener.PlayerID);
 
         switch (controlListener.GameAction)
         {
@@ -135,12 +130,7 @@ private void LoadView()
     {
         foreach (ControlListener controlListener in allListeners)
         {
-            KeysSettings keysSettings;
-
-            if (controlListener.PlayerID == PlayerID.P1)
-                keysSettings = p1KeysSettings;
-            else
-                keysSettings = p2KeysSettings;
+            var keysSettings = GetSettingsByID(controlListener.PlayerID);
 
             switch (controlListener.GameAction)
             {
@@ -241,12 +231,7 @@ private void CheckIfIsTaken(KeyCode keyCode)
             if (controlListener.KeyBinding != keyCode)
                 continue;
 
-            KeysSettings keysSettings;
-
-            if (selectedPlayer == PlayerID.P1)
-                keysSettings = p1KeysSettings;
-            else
-                keysSettings = p2KeysSettings;
+            var keysSettings = GetSettingsByID(selectedPlayer);
 
             switch (controlListener.GameAction)
             {
@@ -266,4 +251,12 @@ private void CheckIfIsTaken(KeyCode keyCode)
             controlListener.ResetBinding();
         }
     }
+
+    private KeysSettings GetSettingsByID(PlayerID id)
+    {
+        if (id == PlayerID.P1)
+            return p1KeysSettings;
+        else
+            return p2KeysSettings;
+    }
 }