Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LoadFromBag assumptions causing C++ exceptions during serialization #438

Merged
merged 6 commits into from
Jul 28, 2024
Merged

Fix LoadFromBag assumptions causing C++ exceptions during serialization #438

merged 6 commits into from
Jul 28, 2024

Commits on Jul 19, 2024

  1. Fix LoadFromBag assumptions 

    * Not all bags have only GridMap messages
* Not all bags have GridMap on the right topic
* Add test for trying to load a grid map from a bag that doesn't
  contain it on the expected topic
* Add nullptr check on reader messages

Signed-off-by: Ryan Friedman <[email protected]>
    @Ryanf55
    Ryanf55 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5038df2 View commit details
    Browse the repository at this point in the history

  2. Remove unused include 

    Signed-off-by: Ryan Friedman <[email protected]>
    @Ryanf55
    Ryanf55 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    204d490 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Add more tests and fix linter 

    Signed-off-by: Ryan Friedman <[email protected]>
    @Ryanf55
    Ryanf55 committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    050bf77 View commit details
    Browse the repository at this point in the history

  2. Add missing slash on topic name 

    Signed-off-by: Ryan Friedman <[email protected]>
    @Ryanf55
    Ryanf55 committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    8ac9420 View commit details
    Browse the repository at this point in the history

  3. Don't skip reporting when tests fail 

    Signed-off-by: Ryan Friedman <[email protected]>
    @Ryanf55
    Ryanf55 committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    ca336bd View commit details
    Browse the repository at this point in the history

  4. Fix linters 

    Signed-off-by: Ryan Friedman <[email protected]>
    @Ryanf55
    Ryanf55 committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    ed219dd View commit details
    Browse the repository at this point in the history