Fix bug in decaying generators #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 20, 2024 19:57
Instead of counting the event number with three different variables, we now use a single variable that is a boolean to distinguish between the beam-like half of the event and the reacion-like half of the event.
Make the modification of the boolean more explicit so the behavior is more clear.
This class covers if the generator should be run or not depending on which type of event we are runnning. It should also handle if there is a child generator that still needs to run and will only mark the reaction event complete if all generators have been run.
Because we are setting the event type at the end of the generator phase (adding particles to the primary track), we loose the information about if it is reaction/beam in the stepping phase where `ProcessHits` is called. To account for this we use the trackID to determine what the event type is. Alternatively, we could check AtVertexPropogator we would just have to invert it To account for hehavior in `AtTPC2Body` generator added flag to `AtReactionGenerator` to allow for any reaction to always run (even if it is a beam- like event).
By definition, if an AtReactionGenerator is running then it can create new particles. We should not check for if it is a reaction event. That is handled by the base class only and should be hidden from users implementing generators.
- Move all tests to the same directory as the source files so they are easier to locate in the project structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the beam and decays were both being generated in a single event.
This also has some initial work (used to fix bug) to more fully separate out "reaction" generators from "beam" generators. The reaction generators now all derive from a single class, and that class manages when the generators can add particles to the stack. If all is working properly, the user can ignore the two event structure and assume that if we are calling their
GenerateReaction()function, then they should be producing particles.