Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update npm / third-party libraries #187

Closed
Lorsbyjm opened this issue Nov 29, 2018 · 4 comments
Closed

update npm / third-party libraries #187

Lorsbyjm opened this issue Nov 29, 2018 · 4 comments
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user
Milestone

Comments

@Lorsbyjm
Copy link
Contributor

Lorsbyjm commented Nov 29, 2018

create new branch
run npm audit and check whats wrong
for more information talk to Lukas :D


Remaining alerts:

@sleidig sleidig added Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user and removed Type: Bug labels Dec 12, 2018
@sleidig
Copy link
Member

sleidig commented Dec 12, 2018

npm audit shows security vulnerabilities of our dependencies/libraries. Seems to be the same as what github is analysing: https://github.com/NGO-DB/ndb-core/network/alerts ?

I think someone should look into a major update of all libraries, including to Angular 7 (run npm outdated for an overview of latest versions).
Any volunteers?

@sleidig sleidig changed the title update npm update npm / third-party libraries Dec 12, 2018
@liwde
Copy link
Contributor

liwde commented Dec 20, 2018

The Angular CLI seems to have some tools to support especially major version upgrades: https://angular.io/cli/update

However, some things already made their way into #204 -- we should wait, until this is merged, before branching and getting conflicts in the package-lock.json.

@RichardNutt
Copy link
Contributor

RichardNutt commented Dec 20, 2018

see https://update.angular.io/

Before Updating

  • Switch from HttpModule and the Http service to HttpClientModule and the HttpClient service. HttpClient simplifies the default ergonomics (You don't need to map to json anymore) and now supports typed return values and interceptors. Read more on angular.io
  • Remove deprecated RxJS 6 features using rxjs-tslint auto update rules
  • Once you and all of your dependencies have updated to RxJS 6, remove rxjs-compat.
  • If you use the Angular Service worker, migrate any versionedFiles to the files array. The behavior is the same.

During the Update

  • Angular now uses TypeScript 3.1, read more about any potential breaking changes
  • Update to v7 of the core framework and CLI by running ng update @angular/cli @angular/core in your terminal
  • Update Angular Material to v7 by running ng update @angular/material in your terminal. You should test your application for sizing and layout changes.

After the Update

  • Stop using matRippleSpeedFactor and baseSpeedFactor for ripples, using Animation config instead.

@sleidig sleidig added this to the [v2.6] milestone Jan 7, 2019
@sleidig
Copy link
Member

sleidig commented Jan 7, 2019

I think we'll have to pin the typescript dependency to <3.2 for the time being.

liwde pushed a commit that referenced this issue Jan 17, 2019
* updated the deprecated HttpModule to HttpClientModule

* removed deprecated RxJS 6 features and rxjs-compat

* updated dependencies (doesn't compile; some dependency is using typescript 3.2.2)

* further dependency updates and fixes for breaking changes

see #187

* remove "typings" dependency. unneeded as we are using @types

* fixed lint errors

* Update some more dependencies and fix breaking change in flex-layout

There was an undocumented breaking change. See:
angular/flex-layout#885
angular/flex-layout@1205588#diff-9caf78031951b821123260bf7bc8e031
@liwde liwde closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user
Projects
None yet
Development

No branches or pull requests

4 participants