Add a simple Bump node #1085
Merged
Add a simple Bump node #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a node to simplify adding bump to shading graphs. It's just a wrapper around existing nodes.
kwokcb
reviewed
Oct 5, 2022
…'scale' to drive the normalmap node.
libraries/stdlib/stdlib_defs.mtlx
Outdated
| <nodedef name="ND_bump_vector3" node="bump" nodegroup="geometric"> | ||
| <input name="height" type="float" uiname="Height" uisoftmin="0.0" uisoftmax="1.0" value="0" doc="Amount to offset the surface normal." /> | ||
| <input name="scale" type="float" uiname="Scale" uisoftmin="0.0" uisoftmax="1.0" value="1" doc="Scalar to adjust the height amount." /> | ||
| <input name="space" type="string" value="tangent" enum="tangent, object" uniform="true" doc="The space to transform the normal from ('tangent' or 'object'); defaults to 'tangent'" /> |
There was a problem hiding this comment.
I believe we can remove this space input, and assume the normal map is in tangent space, since the heighttonormal node is designed to generate a map in this space. In the latest draft of MaterialX 1.39, the space input has been removed from the normalmap node, so removing the input should make the bump node more forward-looking.
This changelist removes the input elements from the functional nodegraph for the new bump node, since they don't have any effect in MaterialX. (In an upcoming change, I'd like to add a validation warning for this case, since it comes up often.)
jstone-lucasfilm
approved these changes
Oct 25, 2022
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
This adds a MtlX Bump node. It simplifies adding bump to shaders by wrapping up the necessary nodes, which helps artists using MaterialX. Having a node called 'bump' also makes it easier to discover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a MtlX Bump node. It simplifies adding bump to shaders by wrapping up the necessary nodes, which helps artists using MaterialX. Having a node called 'bump' also makes it easier to discover.
Thanks!