Fix implementation of screen node #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This is what they look like before the fix: After discussion with @niklasharrysson it was concluded that alpha is treated differently between GLSL and OSL in the tests. The difference between GLSL and OSL on screen_color4 is due to alpha=0.5 with the old screen implementation. |
The parenthesis were incorrectly placed in the implementation of the screen compositing node. Changes from this: (mix * ((1 - (1 - fg)) * (1 - bg))) + ((1 - mix) * bg) to this: (mix * ((1 - (1 - fg) * (1 - bg)))) + ((1 - mix) * bg)
rasmusbonnedal
force-pushed
the
fix-screen-node
branch
from
80f8e64
to
04dae96
Compare
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Oct 22, 2022
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
The parentheses were incorrectly placed in the implementation of the screen compositing node.
Changes from this:
(mix * ((1 - (1 - fg)) * (1 - bg))) + ((1 - mix) * bg)
to this:
(mix * ((1 - (1 - fg) * (1 - bg)))) + ((1 - mix) * bg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parenthesis were incorrectly placed in the implementation of the screen compositing node.
Changes from this:
(mix * ((1 - (1 - fg)) * (1 - bg))) + ((1 - mix) * bg)to this:
(mix * ((1 - (1 - fg) * (1 - bg)))) + ((1 - mix) * bg)