Fix "unbind geometry" MaterialXView OpenGL errors on MacOS #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstone-lucasfilm
approved these changes
Oct 30, 2022
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…ftwareFoundation#1126) In GlslProgram::unbindGeometry, glDisableVertexAttribArray is called. According to the specification (https://registry.khronos.org/OpenGL-Refpages/gl4/html/glEnableVertexAttribArray.xhtml), this requires a vertex array to be bound, which is not the case. On MacOS, the driver seems to be less lenient and returns an error which is then printed as "OpenGL error after program unbind geometry: 1282". Since we destroy the vertex array a few lines later, there's no need to disable the attributes. Removing the glDisableVertexAttribArray calls fixes the errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
GlslProgram::unbindGeometry, glDisableVertexAttribArray is called. According to the specification, this requires a vertex array to be bound, which is not the case. On MacOS, the driver seems to be less lenient and returns an error which is then printed as "OpenGL error after program unbind geometry: 1282".Since we destroy the vertex array a few lines later, there's no need to disable the attributes.
Removing the glDisableVertexAttribArray calls fixes the errors.