Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opacity edge case in UsdPreviewSurface #1186

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix opacity edge case in UsdPreviewSurface #1186

merged 1 commit into from
Jan 4, 2023

Conversation

jstone-lucasfilm
Copy link
Member

This changelist fixes an edge case for the opacity computation in UsdPreviewSurface, making surfaces visible when their non-zero opacity is exactly equal to the opacity threshold.

This aligns the MaterialX graph for UsdPreviewSurface with its specification (https://graphics.pixar.com/usd/release/spec_usdpreviewsurface.html), which states:

"... when opacityThreshold is greater than zero, the opacity values less than the opacityThreshold will not be rendered, and the opacity values greater than or equal to the opacityThreshold will be fully visible."

This changelist fixes an edge case for the opacity computation in UsdPreviewSurface, making surfaces visible when their non-zero opacity is exactly equal to the opacity threshold.

This aligns the MaterialX graph for UsdPreviewSurface with its specification (https://graphics.pixar.com/usd/release/spec_usdpreviewsurface.html), which states:

"... when opacityThreshold is greater than zero, the opacity values less than the opacityThreshold will not be rendered, and the opacity values greater than or equal to the opacityThreshold will be fully visible."
@jstone-lucasfilm
Copy link
Member Author

Thanks to @klucknav and @spiffmon for noting this issue, and I've CC'ed them both for validation of this proposed change.

@jstone-lucasfilm jstone-lucasfilm merged commit 01fc05f into AcademySoftwareFoundation:main Jan 4, 2023
Michaelredaa pushed a commit to Michaelredaa/MaterialX that referenced this pull request Oct 21, 2023
…#1186)

This changelist fixes an edge case for the opacity computation in UsdPreviewSurface, making surfaces visible when their non-zero opacity is exactly equal to the opacity threshold.

This aligns the MaterialX graph for UsdPreviewSurface with its specification (https://graphics.pixar.com/usd/release/spec_usdpreviewsurface.html), which states:

"... when opacityThreshold is greater than zero, the opacity values less than the opacityThreshold will not be rendered, and the opacity values greater than or equal to the opacityThreshold will be fully visible."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant