Graph Editor Property Panel Formatting #1346
Conversation
|
@lfl-eholthouser, @jstone-lucasfilm . I have pulled out the formatting UI work into this separate PR. |
| @@ -818,7 +818,7 @@ void Graph::updateMaterials(mx::InputPtr input, mx::ValuePtr value) | |||
| void Graph::setConstant(UiNodePtr node, mx::InputPtr& input, const mx::UIProperties& uiProperties) | |||
| { | |||
| std::string inName = !uiProperties.uiName.empty()? uiProperties.uiName : input->getName(); | |||
| float labelWidth = ImGui::CalcTextSize(inName.c_str()).x; | |||
| ImGui::PushItemWidth(-1); | |||
There was a problem hiding this comment.
Right alignment is "easy" by using -1.
| @@ -854,13 +851,10 @@ void Graph::setConstant(UiNodePtr node, mx::InputPtr& input, const mx::UIPropert | |||
| if (val && val->isA<int>()) | |||
| { | |||
| int prev = val->asA<int>(), temp = val->asA<int>(); | |||
| ImGui::SameLine(); | |||
There was a problem hiding this comment.
All of these "same lines" are not needed in general since items are added into table cells.
| @@ -3134,63 +3110,94 @@ void Graph::propertyEditor() | |||
| } | |||
| } | |||
|
|
|||
| const float TEXT_BASE_HEIGHT = ImGui::GetTextLineHeightWithSpacing() * 1.3f; | |||
| const int SCROLL_LINE_COUNT= 20; | |||
There was a problem hiding this comment.
This can be tweaked as needed. About 20 items seems reasonable now for a scroll area, and the table has no borders. I assume when UI grouping support is added these can be collapsible areas and scroll bars may not be needed as much since each group has less items. For another PR.
| @@ -3274,7 +3320,9 @@ void Graph::propertyEditor() | |||
|
|
|||
| if (ImGui::BeginPopup("docstring")) | |||
| { | |||
| ImGui::SetWindowFontScale(_fontScale); | |||
There was a problem hiding this comment.
Minor update to make the font size more readable.
|
This looks great to me, @kwokcb, and I'd be interested in thoughts from @lfl-eholthouser as well. |
|
This looks great to me as well! Thanks! @kwokcb |
Add some table formatting for property panel in graph editor. * Shows 2 columns with either the connection type (as before) or the value (as before). Second column is aligned right and first column aligned left. * Table has vertical scroll-bar.
Add some table formatting for property panel in graph editor.
Sample New Formatting
Vs old formatting