Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OSL generation of filename inputs #1547

Conversation

niklasharrysson
Copy link
Contributor

This change list modifies the generation of public filename parameters from being a textureresource struct, to being two separate string parameters for filename and colorspace.

This is to solve the issue discussed in #1463.

// Add shader input metadata.
//

auto widgetMetadataIt = UI_WIDGET_METADATA.find(input->getType());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata generation was moved out to a separate method, see below.

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @niklasharrysson!

@jstone-lucasfilm jstone-lucasfilm changed the title Improve generation of 'filename' inputs for OSL shaders Improve OSL generation of filename inputs Oct 9, 2023
@jstone-lucasfilm jstone-lucasfilm merged commit c7f01d8 into AcademySoftwareFoundation:main Oct 9, 2023
31 checks passed
Michaelredaa pushed a commit to Michaelredaa/MaterialX that referenced this pull request Oct 21, 2023
…1547)

This change list modifies the generation of public filename parameters from being a textureresource struct, to being two separate string parameters for filename and colorspace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants