Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Graph Editor from creating imgui.ini file #1570

Merged

Conversation

iukpo-lucasfilm
Copy link
Contributor

Added code to stop creation of imgui.ini after saving material after saving then closing Graph Editor (#1471)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @iukpo-lucasfilm!

Although we may want to revisit the notion of configuration INI files in future iterations, I would recommend that we remove the getConfigPath helper function from Main.cpp as part of your change, since it was added specifically for the graph editor INI use case.

The function will always be available in the GitHub history of the MaterialX project, and we can bring it back if configuration INI files become valuable in the future.

@iukpo-lucasfilm
Copy link
Contributor Author

@jstone-lucasfilm Thank you! I will remove getConfigPath, as requested.

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to merge, thanks @iukpo-lucasfilm!

@jstone-lucasfilm jstone-lucasfilm merged commit 7446251 into AcademySoftwareFoundation:main Oct 14, 2023
31 checks passed
@iukpo-lucasfilm iukpo-lucasfilm deleted the Issue_1471 branch October 15, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants