Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ND_normalmap to ND_normalmap_float in 1.39 #1677

Conversation

ld-kerley
Copy link
Contributor

@ld-kerley ld-kerley commented Jan 26, 2024

Renaming ND_normalmap -> ND_normalmap_float

Added upgrade mechanism to handle the node definition rename.

@ld-kerley ld-kerley force-pushed the update_stdlib_normalmap_for_1_39 branch from 67c99f2 to d05b2fe Compare January 26, 2024 04:19
Signed-off-by: Jonathan Stone <[email protected]>
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, @ld-kerley, and I'm CC'ing @ashwinbhat and @JGamache-autodesk to make sure we're not missing any implications for MaterialX 1.38 content embedded in USD stages.

@JGamache-autodesk
Copy link
Contributor

USD stages will systematically hardcode the nodedef string into the info:id attribute of the UsdShade nodes. This means all USD persisted data will need an upgrade path to 1.39, and also potentially require storing the MaterialX version somewhere in the document to know if an upgrade is required.

We need to start the discussion with the AOUSD WG because that might become an adoption blocker for MaterialX 1.39.

@jstone-lucasfilm
Copy link
Member

Thanks for that context, @JGamache-autodesk, and that's the perspective I was hoping you could provide here. I wonder if the USD project could begin versioning its own documents when it upgrades to MaterialX 1.39, which would allow MaterialX 1.38 content embedded in legacy USD stages to be robustly upgraded to MaterialX 1.39. The logic that @ld-kerley has proposed here would then work universally for MaterialX content, regardless of the file format in which it has been encoded.

@jstone-lucasfilm jstone-lucasfilm changed the title 1.39 update - rename ND_normalmap to ND_normalmap_float Rename ND_normalmap to ND_normalmap_float in 1.39 Jan 28, 2024
@jstone-lucasfilm
Copy link
Member

We'll need to address the USD versioning question before the OpenUSD project can upgrade to MaterialX 1.39, as even the simplest possible update to a node interface (e.g. #1659) will require that the MaterialX version of the source document is known.

My sense is that we should move forward with this specific change from @ld-kerley, keeping the need for USD versioning in our minds as an important topic for upcoming USD/MaterialX working group meetings.

@jstone-lucasfilm jstone-lucasfilm merged commit 779f346 into AcademySoftwareFoundation:dev_1.39 Jan 31, 2024
31 checks passed
@ld-kerley ld-kerley deleted the update_stdlib_normalmap_for_1_39 branch May 21, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants