Add matrix type conditional nodes #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge in TDGNUIIT/materialx from add_matrix_conditional_nodes to internal Squashed commit of the following: commit ff6082185d66b54a376066e4a5b52d9e92d0378c Author: Lee Kerley <[email protected]> Date: Wed Apr 17 14:21:18 2024 -0700 add ND_ifequal_matrix33, ND_ifequal_matrix44, ND_ifequal_matrix33I, ND_ifequal_matrix44I, ND_ifequal_matrix33B, ND_ifequal_matrix44B, ND_ifgreater_matrix33, ND_ifgreater_matrix44, ND_ifgreater_matrix33I, ND_ifgreater_matrix44I, ND_ifgreatereq_matrix33, ND_ifgreatereq_matrix44, ND_ifgreatereq_matrix33I, ND_ifgreatereq_matrix44I node definitions
ld-kerley
force-pushed
the
add_matrix_conditional_nodes
branch
from
08dbbc3
to
ff3320c
Compare
jstone-lucasfilm
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
This looks great to me, thanks @ld-kerley, and I'm CC"ing @dbsmythe and @krohmerNV for their thoughts.
jstone-lucasfilm
merged commit 7739474
into
AcademySoftwareFoundation:dev_1.39
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ND_ifequal_matrix33ND_ifequal_matrix44ND_ifequal_matrix33IND_ifequal_matrix44IND_ifequal_matrix33BND_ifequal_matrix44BND_ifgreater_matrix33ND_ifgreater_matrix44ND_ifgreater_matrix33IND_ifgreater_matrix44IND_ifgreatereq_matrix33ND_ifgreatereq_matrix44ND_ifgreatereq_matrix33IND_ifgreatereq_matrix44I