Fix the 'creatematrix' shader default output value #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a copy-paste typo in the fourth vector. After the fix, the new output's default value is an identity matrix, as intended.
jstone-lucasfilm
approved these changes
Apr 25, 2024
jstone-lucasfilm
merged commit 0faed78
into
AcademySoftwareFoundation:dev_1.39
61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'nodedef' elements for the ND_creatematrix_vector3_matrix44 and ND_creatematrix_vector4_matrix44 shader definitions have a typo in their default value for the "out" output. The last vector currently is (1,0,0,0) but should be (0,0,0,1), to form an identity matrix. This pull request fixes that.