Initial support for Zeltner sheen #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first version of the GLSL implementation, which is currently inactive but can be enabled in place of the existing sheen model via the SHEEN_METHOD #define in mx_sheen_bsdf.glsl. In contrast to the reference implementation (https://github.com/tizian/ltc-sheen), this version uses analytic fits instead of a table, to ease integration. I plan to improve the quality of the fits in the future (particularly the directional albedo), and also add a sampling function. Remove debug code
|
The macOS shader validation test is currently failing due to the MSL backend lacking support for |
jstone-lucasfilm
approved these changes
May 24, 2024
There was a problem hiding this comment.
This looks great to me, thanks @shill-lucasfilm, and the new code is lightweight enough that I believe we can move forward with a merge, making additional refinements in future pull requests.
jstone-lucasfilm
merged commit 28f8e8d
into
AcademySoftwareFoundation:dev_1.39
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first version of the GLSL implementation, which is currently inactive but can be enabled in place of the existing sheen model via the
SHEEN_METHOD#defineinmx_sheen_bsdf.glsl.In contrast to the reference implementation (https://github.com/tizian/ltc-sheen), this version uses analytic fits instead of a table, to ease integration. I plan to improve the quality of the fits in the future (particularly the directional albedo), and also add a sampling function.