Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adsk Contrib - Enhanced methods to find an equivalent color space bet…
…ween configs (#1788) * - Implementation of identifyInterchangeSpace, identifyBuiltinColorSpace and AreProcessorsEquivalent. - Remove some include of Processor.h where it wasn't needed. Signed-off-by: Cédrik Fuoco <[email protected]> * Moving code from Config.cpp to ConfigUtils.cpp and using wrapper in Config.cpp instead. Fixing identations issues. Fixing styling issues. Signed-off-by: Cédrik Fuoco <[email protected]> * Typo and comments tweaks Moving the creation of the editable config into the wrapper of isColorSpaceLinear instead of doing it inside the function. Signed-off-by: Cédrik Fuoco <[email protected]> * Splitting identifyInterchangeSpace into two methods, one for source config and one for builtin. Adding back isColorSpaceLinear inside Config.cpp since we need access to getProcessorWithoutCaching. Refactor some of config utils function to return index instead of string. Creating editable config in the two wrappers to prevent processor caching. Signed-off-by: Cédrik Fuoco <[email protected]> * Tentative change to phase out isProcessorEquivalent. Signed-off-by: Cédrik Fuoco <[email protected]> * Refactor code and add tests Signed-off-by: Doug Walker <[email protected]> * Remove unused method Signed-off-by: Doug Walker <[email protected]> * Remove unused method, tk 2 Signed-off-by: Doug Walker <[email protected]> * Tweak comments Signed-off-by: Doug Walker <[email protected]> * Python binding for IdentifyInterchangeSpace and IdentifyBuiltinColorSpace methods. Adding a couple python unit tests to cover the new methods (same unit test as the C++ side, but not all of them) Signed-off-by: Cédrik Fuoco <[email protected]> * - Implementation of identifyInterchangeSpace, identifyBuiltinColorSpace and AreProcessorsEquivalent. - Remove some include of Processor.h where it wasn't needed. Signed-off-by: Cédrik Fuoco <[email protected]> * Moving code from Config.cpp to ConfigUtils.cpp and using wrapper in Config.cpp instead. Fixing identations issues. Fixing styling issues. Signed-off-by: Cédrik Fuoco <[email protected]> * Typo and comments tweaks Moving the creation of the editable config into the wrapper of isColorSpaceLinear instead of doing it inside the function. Signed-off-by: Cédrik Fuoco <[email protected]> * Splitting identifyInterchangeSpace into two methods, one for source config and one for builtin. Adding back isColorSpaceLinear inside Config.cpp since we need access to getProcessorWithoutCaching. Refactor some of config utils function to return index instead of string. Creating editable config in the two wrappers to prevent processor caching. Signed-off-by: Cédrik Fuoco <[email protected]> * Tentative change to phase out isProcessorEquivalent. Signed-off-by: Cédrik Fuoco <[email protected]> * Refactor code and add tests Signed-off-by: Doug Walker <[email protected]> * Remove unused method Signed-off-by: Doug Walker <[email protected]> * Remove unused method, tk 2 Signed-off-by: Doug Walker <[email protected]> * Tweak comments Signed-off-by: Doug Walker <[email protected]> * Python binding for IdentifyInterchangeSpace and IdentifyBuiltinColorSpace methods. Adding a couple python unit tests to cover the new methods (same unit test as the C++ side, but not all of them) Signed-off-by: Cédrik Fuoco <[email protected]> * Fixing problem with the rebase Signed-off-by: Cédrik Fuoco <[email protected]> * Make sure the unit test is using the static method Signed-off-by: Cédrik Fuoco <[email protected]> --------- Signed-off-by: Cédrik Fuoco <[email protected]> Signed-off-by: Doug Walker <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]> Co-authored-by: Doug Walker <[email protected]>
- Loading branch information