Built-In Transform support for Apple Log #1941
Conversation
Signed-off-by: Joseph Goldstone <[email protected]>
Signed-off-by: Joseph Goldstone <[email protected]>
There was a problem hiding this comment.
Looks great, thank you Joseph!
One more piece needs to be added. There is a check that is done in Config.cpp to ensure that a given version of the config format does not use Builtin functions that are for a newer version. Apple Log will be the first builtin added for config format 2.4, so please add a new section here that tests if the new builtin is being used with older formats.
…void clipping input Signed-off-by: Joseph Goldstone <[email protected]>
Signed-off-by: Joseph Goldstone <[email protected]>
…teral); bump LastSupportedMinorVersion to 4 Signed-off-by: Joseph Goldstone <[email protected]>
…o be 4, not 3 Signed-off-by: Joseph Goldstone <[email protected]>
|
Thanks, both of you, for the speedy review. Not having write access myself, could I ask one of you to merge the request and close this out? |
|
Let’s wait for Robert to take a look, please. I’ve let him know it’s up. |
|
This would be a good PR to add as a developer guide example, i.e., how to add a new transformation. |
|
To Thomas' point, yes, including the introspective aspects, i.e. not allowing the new builtins to be used in pre-3.4 configs, and being the first thing in a release to have such a constraint. |
|
Looks good to me - thank you Joseph! |
|
@rkmolholm , after looking at the results, I'm not sure this transform is correct. It may simply be that the footage I have was not correctly captured. Could you point us at some known good test material in Apple Log space? |
Address request for Apple Log support as raised in #1916