Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate asset-registry benchmark #2767

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Jun 5, 2024

@zjb0807 zjb0807 requested a review from xlc June 5, 2024 18:16
@zjb0807
Copy link
Member Author

zjb0807 commented Jun 5, 2024

  • /bench runtime mandala *

Comment on lines +20 to +22
module-evm = { workspace = true }
serde_json = { workspace = true }
hex = { workspace = true }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new benchmark requires importing the associated module as a dependency, which I’m not sure is what we want.

set_block_number_timestamp(1, 24000);
DexOracle::on_initialize(1)

the dex-oracle need to import the module-currencies, module-dex, pallet-aura, pallet-balances, pallet-timestamp, sp-consensus-aura, it feels too bulky

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we mock it?

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 65.30%. Comparing base (a6bb42c) to head (6baf951).

Files Patch % Lines
modules/asset-registry/src/benchmarks.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2767      +/-   ##
==========================================
- Coverage   65.49%   65.30%   -0.20%     
==========================================
  Files          69       69              
  Lines        9885     9522     -363     
==========================================
- Hits         6474     6218     -256     
+ Misses       3411     3304     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants