-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate asset-registry benchmark #2767
base: master
Are you sure you want to change the base?
Conversation
|
module-evm = { workspace = true } | ||
serde_json = { workspace = true } | ||
hex = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new benchmark requires importing the associated module as a dependency, which I’m not sure is what we want.
Acala/runtime/mandala/src/benchmarking/dex_oracle.rs
Lines 51 to 52 in a6bb42c
set_block_number_timestamp(1, 24000); | |
DexOracle::on_initialize(1) |
the dex-oracle need to import the
module-currencies
, module-dex
, pallet-aura
, pallet-balances
, pallet-timestamp
, sp-consensus-aura
, it feels too bulky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we mock it?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2767 +/- ##
==========================================
- Coverage 65.49% 65.30% -0.20%
==========================================
Files 69 69
Lines 9885 9522 -363
==========================================
- Hits 6474 6218 -256
+ Misses 3411 3304 -107 ☔ View full report in Codecov by Sentry. |
#2766