Merge pull request #44 from Accenture/detect-SSML-in-texts

Detect ssml tag <speak>in response texts
Accenture · Dec 19, 2016 · d2a0c22 · d2a0c22
2 parents 60f78ff + bda2be8
commit d2a0c22
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 5 deletions.
diff --git a/src/handle-request.js b/src/handle-request.js
@@ -244,12 +244,12 @@ const createResponse = (options, slots, attrs, app) => {
  */
 const createOutputSpeechObject = (text, ssml) => {
   let outputSpeech = {};
-  if (!ssml) {
-    outputSpeech.type = 'PlainText';
-    outputSpeech.text = text;
-  } else {
+  if (text.includes('<speak>') || ssml) {
     outputSpeech.type = 'SSML';
     outputSpeech.ssml = text;
+  } else {
+    outputSpeech.type = 'PlainText';
+    outputSpeech.text = text;
   }
   return outputSpeech;
 };
diff --git a/test/basic.spec.js b/test/basic.spec.js
@@ -116,8 +116,18 @@ describe('basic app handler', () => {
     });
   });
 
+  it('should handle IntentC request with SSML outputSpeech type', (done) => {
+    const request = alexia.createIntentRequest('IntentC', null, attrs, false, 'appId1');
+
+    app.handle(request, (response) => {
+      attrs = response.sessionAttributes;
+      expect(response.response.outputSpeech).to.deep.equal({type: 'SSML', ssml: '<speak>Hi</speak>'});
+      done();
+    });
+  });
+
   it('should handle async intent', (done) => {
-    const request = alexia.createIntentRequest(intents[11].name, null, null, false, 'appId1');
+    const request = alexia.createIntentRequest(intents[12].name, null, null, false, 'appId1');
 
     app.handle(request, (response) => {
       expect(response.response.outputSpeech.text).equal('I just did stuff asynchronously. Thank you for this opportunity');

diff --git a/test/mock/assets.js b/test/mock/assets.js
@@ -19,6 +19,7 @@ exports.intentSchema = {
     {intent: 'AMAZON.CancelIntent'},
     {intent: 'IntentA'},
     {intent: 'IntentB'},
+    {intent: 'IntentC'},
     {intent: 'e'},
     {intent: 'AnotherCardIntentSample'},
     {intent: 'IntentWithoutUtterances'}
@@ -39,6 +40,7 @@ exports.utterances = [
   'AMAZON.HelpIntent yup',
   'IntentA another utterance',
   'IntentB another utterance',
+  'IntentC another utterance',
   'e async response',
   'AnotherCardIntentSample card intent'
 ];

diff --git a/test/test-apps/basic-app.js b/test/test-apps/basic-app.js
@@ -65,6 +65,12 @@ app.intent('IntentB', 'another utterance', (slots, attrs) => {
   return `attribute value is ${attrs.yes}`;
 });
 
+app.intent('IntentC', 'another utterance', (slots, attrs) => {
+  return {
+    text: '<speak>Hi</speak>'
+  };
+});
+
 app.intent(null, 'async response', (slots, attrs, data, done) => {
   setTimeout(() => {
     done('I just did stuff asynchronously. Thank you for this opportunity');