Update with ros2/geometry #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use correct method to get node time.
In the MessageFilter class, use node interfaces instead of using the node directly so that the code works with either rclcpp::Node or rclcpp_lifecycle::LifecycleNode. Retain the existing node-based interface for backwards compatibility.
* Fixed ros2#658 Signed-off-by: ivanpauno <[email protected]> * Modified Eigen include directory again Signed-off-by: ivanpauno <[email protected]> * Deleted custom variable 'Eigen_INCLUDE_DIR' Signed-off-by: ivanpauno <[email protected]> * revert unrelated whitespace change Signed-off-by: ivanpauno <[email protected]> * Added Eigen message again Signed-off-by: ivanpauno <[email protected]>
* use node interfaces Signed-off-by: Karsten Knese <[email protected]> * do not store a copy of topic interface Signed-off-by: Karsten Knese <[email protected]> * initialization style Signed-off-by: Karsten Knese <[email protected]>
|
ping |
|
Reviewing
El El vie, 26 abr 2019 a las 9:16, Alejandro Hernández Cordero <
[email protected]> escribió:
… ping
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKPYDT3YUBQGBMKPJJOXVLPSKT4HANCNFSM4HIO5BCA>
.
|
anasarrak
approved these changes
Apr 26, 2019
|
It compiles everything for me |
|
My first reaction is that this is problematic because the "most updated" branch in master which contains bits also from other PRs. See
I'm seeing what's the impact on the master branch. Please hold it for now. |
|
Closed on behalf of #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.