Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake #125

Merged
merged 3 commits into from
Jul 11, 2019
Merged

Fix cmake #125

merged 3 commits into from
Jul 11, 2019

Conversation

kazuki0824
Copy link

@kazuki0824 kazuki0824 commented Jul 5, 2019 •
edited
Loading

Description

I have fixed build scripts. Please check it out.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Document API changes relevant to the user in the moveit/MIGRATION.md notes
  • Created tests, which fail without this PR reference
  • Decide if this should be cherry-picked to other current ROS branches

@kazuki0824 kazuki0824 mentioned this pull request Jul 5, 2019
Open
@vmayoral
Copy link

vmayoral commented Jul 7, 2019

@ahcorde can you review this please?

LanderU
LanderU approved these changes Jul 7, 2019
View reviewed changes
Copy link

@LanderU LanderU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a quick look, LGTM, but let's wait until @ahcorde share his opinion.

@ahcorde ahcorde merged commit 2920b4c into AcutronicRobotics:master Jul 11, 2019
@ahcorde
Copy link

ahcorde commented Jul 11, 2019

Thanks for the PR @kazuki0824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@LanderU LanderU LanderU approved these changes

@anasarrak anasarrak anasarrak approved these changes

Assignees

@ahcorde ahcorde

@LanderU LanderU

@anasarrak anasarrak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kazuki0824 @vmayoral @ahcorde @LanderU @anasarrak