Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After saving segment with a custom name to a preset a preset cannot be saved with the default segment name to show time using scrolling text. #3526

Closed
1 task done
eoncire opened this issue Nov 15, 2023 · 9 comments
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master question

Comments

@eoncire
Copy link

eoncire commented Nov 15, 2023

What happened?

I have a 16x16 2d matrix set up which I am using to display text. I created a preset with a named segment "Hello" to display that text when the preset is loaded. I created another preset after I blanked / reset the segment name hoping to have a preset to return to the time display. It appears that when the preset is saved with a blank segment name there is no "n" value in the preset JSON. I have tried to modify the preset JSON before saving to add a "blank" "n" value but it did not work.

To Reproduce Bug

Using a 2d matrix and the "Scrolling Text" effect;

  1. Give the primary (only) segment a name of "Hello" and click the check box to apply.
    a. The matrix displays "Hello"
  2. Create a new preset in Error Compiling #1 and save.
  3. Erase / blank the segment name and click the check box to apply.
    b. The matrix displays the time / date
  4. Create a new preset in ESP32 support & flickering #2 and save.
  5. Load preset Error Compiling #1 and the matrix shows the text "Hello"
  6. Load preset ESP32 support & flickering #2 and nothing changes.

Expected Behavior

When loading preset #2 in the above example the time / date should be shown.

Install Method

Binary from WLED.me

What version of WLED?

0.14.0

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@eoncire eoncire added the bug label Nov 15, 2023
@blazoncek
Copy link
Collaborator

Please post preset content.

@eoncire
Copy link
Author

eoncire commented Nov 15, 2023

Please post preset content.

This is the preset content with the "blank" segment name which should show the time. If i load a preset with a segment named "Hello" it will display "Hello" on the matrix. If I select the below preset after nothing will change.

{"on":true,"bri":255,"transition":7,"mainseg":0,"seg":[{"id":0,"start":0,"stop":16,"startY":0,"stopY":16,"grp":1,"spc":0,"of":0,"on":true,"frz":false,"bri":255,"cct":127,"set":0,"col":[[8,255,0],[0,0,255],[8,255,0]],"fx":122,"sx":255,"ix":128,"pal":2,"c1":0,"c2":162,"c3":16,"sel":true,"rev":false,"mi":false,"rY":false,"mY":false,"tp":false,"o1":false,"o2":false,"o3":false,"si":0,"m12":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0}]}

@blazoncek
Copy link
Collaborator

Add "n":"" into "seg":[{...}] section.
Name may not be added to conserve RAM during processing.

@eoncire
Copy link
Author

eoncire commented Nov 15, 2023

Add "n":"" into "seg":[{...}] section. Name may not be added to conserve RAM during processing.

I added that to the JSON then clicked save, but it doesn't save after the page refreshes.

What i put in.
image

What is there after clicking save.
image

@eoncire
Copy link
Author

eoncire commented Nov 15, 2023

Add "n":"" into "seg":[{...}] section. Name may not be added to conserve RAM during processing.

If I put some other text in the double quotes it will save that and display the text, but it doesn't seem to like having just the double quotes / blank.

@eoncire eoncire closed this as completed Nov 15, 2023
@eoncire eoncire reopened this Nov 15, 2023
@eoncire
Copy link
Author

eoncire commented Nov 15, 2023

Didn't mean to close this issue, clicked the wrong button...

@blazoncek blazoncek added the confirmed The bug is reproducable and confirmed label Nov 15, 2023
@blazoncek
Copy link
Collaborator

Note: when saving preset, if "Save bounds" is unchecked, segment names are not saved.

blazoncek added a commit that referenced this issue Nov 15, 2023
@eoncire
Copy link
Author

eoncire commented Nov 15, 2023

Note: when saving preset, if "Save bounds" is unchecked, segment names are not saved.

Noted. I had "Save Bounds" checked by default when saving these presets. It looks like if the segment name is set to the default it also does NOT save the name.

blazoncek added a commit that referenced this issue Nov 15, 2023
@blazoncek
Copy link
Collaborator

😁
Note was for myself. But I think I fixed the issue.

softhack007 pushed a commit to MoonModules/WLED that referenced this issue Nov 27, 2023
@blazoncek blazoncek added the fixed in source This issue is unsolved in the latest release but fixed in master label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master question
Projects
None yet
Development

No branches or pull requests

3 participants