Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usermod Auto Save not working with 0.14 like before #3533

Closed
1 task done
KrX3D opened this issue Nov 18, 2023 · 1 comment
Closed
1 task done

Usermod Auto Save not working with 0.14 like before #3533

KrX3D opened this issue Nov 18, 2023 · 1 comment
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master

Comments

@KrX3D
Copy link

KrX3D commented Nov 18, 2023

What happened?

Hello,

before with 0.13.3 the usermod Auto Save saved a preset and it looked like this:

{"on":true,"bri":76,"transition":7,"mainseg":0,"seg":[{"id":0,"start":0,"stop":144,"grp":1,"spc":0,"of":0,"on":true,"frz":false,"bri":255,"cct":127,"col":[[250,250,250,51],[0,0,0,0],[0,0,0,0]],"fx":0,"sx":128,"ix":128,"pal":0,"sel":true,"rev":false,"mi":false},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0}]}

but now it looks like this (preset from another device with 0.14)
{"mainseg":0,"seg":[{"id":0,"grp":1,"spc":0,"of":0,"on":true,"frz":false,"bri":255,"cct":127,"set":0,"col":[[255,255,255],[255,255,255],[255,255,255]],"fx":56,"sx":128,"ix":128,"pal":0,"c1":128,"c2":128,"c3":16,"sel":true,"rev":false,"mi":false,"o1":false,"o2":false,"o3":false,"si":0,"m12":0}]}

when i go to preset and hit overwrite with state it looks like this

{"on":false,"bri":128,"transition":7,"mainseg":0,"seg":[{"id":0,"start":0,"stop":343,"grp":1,"spc":0,"of":0,"on":true,"frz":false,"bri":255,"cct":127,"set":0,"col":[[255,255,255],[255,255,255],[255,255,255]],"fx":29,"sx":128,"ix":128,"pal":0,"c1":128,"c2":128,"c3":16,"sel":true,"rev":false,"mi":false,"o1":false,"o2":false,"o3":false,"si":0,"m12":0}]}

it looks like from the usermod not this info is missing:

"on":false,"bri":128,"transition":7,

,"start":0,"stop":343

which also is missing when i deselect the "include brightness" option. So something has changed that Auto Save usermod is not including the brightness to "export" the preset.

also before there where a lot of {"stop":0}, saved and now not so maybe the "checked segments only" is also not working with the usermod

To Reproduce Bug

  • enable Auto Save usermod

  • it saves the "broken" preset

  • save manually the preset and it is different between 0.13.3 and 0.14

Expected Behavior

Auto Save should include the brightness like before, because that way it is now selecting the preset does not set the on/off state

maybe it would be nice to have in the usermod to select those options like in the preset tab:

  • include brightness
  • save segment bounds
  • checked segments only

Install Method

Self-Compiled

What version of WLED?

WLED 0.14

Which microcontroller/board are you seeing the problem on?

ESP32-S2

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@KrX3D KrX3D added the bug label Nov 18, 2023
blazoncek added a commit that referenced this issue Nov 18, 2023
blazoncek added a commit that referenced this issue Nov 18, 2023
@blazoncek blazoncek added confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master labels Nov 18, 2023
@KrX3D
Copy link
Author

KrX3D commented Nov 18, 2023

i tested the fix and it seems ok now. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master
Projects
None yet
Development

No branches or pull requests

2 participants