-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying incorrect 2D settings will make it crash #3889
Comments
I'm sure you can use exception decoder. 😉 |
does this help?
|
It happens in LittleFS while checking if Perhaps you ran out of memory? |
the crash reason at the beginning mentions 'StoreProhibited'. definitely not out of memory, this is on an ESP32 with just 256 LEDs enabled. Here I set it to 2D with 2x 16x16 panel. that works fine, even with just one output defined. the crash happens, when I set the offset of the second panel to 16, which probably writes to a non-existing buffer or out of range of the LED buffer. |
There might be an issue when resizing a matrix as buffer is already allocated from the boot sequence. |
Try this in if (customMappingTable) delete[] customMappingTable;
customMappingTable = new uint16_t[getLengthTotal()]; |
same here. saving 2d settings with 16x16 bottom right serpentime causes my esp-wroom-32 to crash immediately and do not save settings. if there is a bin file with fix I can try it upd. falling back from 0.15-b2 to 0.14.3 fixed the issue |
I tried with the changes in I found out (with this fix only? did not check) the crash also happens when having it on 'solid' color and adding a second panel, with no offset (so overlapping panels). After the crash (no crashdump was created unfortunately) the wifi settings are lost (no connections available):
so seems like the config gets corrupted. After reboot, it starts the AP but it does not save any settings, in fact, it just crashes.
the settings page loads without issues but when saving the wifi settings, this happens:
|
Please read the exception decoder. The crash happens within file system library. Not much can be done about that apart from filing a bug report in ESP platform. I am guessing that you are using 80MHz flash clock which your flash chip may not like. Please lower it to 40MHz and try again. I did fix allocation bug when resizing matrix though. |
Your alloacation fix seems to have resolved this, I cannot get it to crash anymore. |
I checked again with a wiped flash and clean install, does not crash. One more nasty bug fixed, thank you :) |
What happened?
saving incorrect 2D settings while an FX is running causes a crash and settings are not saved.
To Reproduce Bug
setup one 2D panel. I used 256 leds, one output, 1 panel, 16x16.
load Akemi FX, save as preset and apply at boot. then reboot.
without changing LED outputs, go to 2D settings, set to two panels, 16x16 each, set the second one to x-offset=16 (offset is important, I suspect something tries to write to the non-existing leds outside the first 16x16 panel)
apply settings and it does crash.
happens on ESP32 and ESP32 S2 and S3.
was not able to reproduce this on 0.14.3
Expected Behavior
should not crash or at least save the settings.
Install Method
Self-Compiled
What version of WLED?
0.15 (latest at 7. 4. 2024)
Which microcontroller/board are you seeing the problem on?
ESP32
Relevant log/trace output
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: