Updating pxmagic and WLED UI #3296

ajotanc · 2023-07-20T15:27:35Z

Updating pxmagic and inserting it in the WLED UI with option to enable and disable.

This reverts commit b4f08fa.

(saves a few bytes and IE10 is over 10 years old and unsupported) Correct HTML language attribute (Chrome would show a popup asking to translate from Portugese)

…e and disable.

…to enable and disable." This reverts commit 44197d9.

blazoncek · 2023-07-22T10:44:08Z

I've briefly tested this and have a few remarks (this is not a full review).

First off, PXM or Pixel Magic button is inappropriate and IMO does not belong to the button bar.
There is a lot of empty space at the top and the close button is missing (is rendered behind PXM content)
When saving a preset, presets are reloaded before the actual preset is saved.
PXM tool is reloaded every time it is activated which is a waste of resources.
Istead of displaying empty "Select a choice" make uploading an image a default behaviour. Only display drop-down selector if there are actual images stored on device.
Making "Individual" as a default Pattern is potentially problematic as the JSON size will increase beyond usability.
Make sure you use tabs or spaces for indentation as appropriate for each file.

And honestly I do not see any reason to store images on the device as it only consumes FS space (image is stored in JSON format in preset) unless there was a usermod for displaying images in which case this tool would be obsolete.

EDIT: There is JS error when activating tool.

blazoncek · 2023-07-31T19:41:23Z

Any news or updates @ajotanc ?

blazoncek · 2023-08-21T14:37:47Z

@ajotanc ?

ajotanc · 2023-08-22T13:29:05Z

@ajotanc ?

I had some personal problems, that's why I wasn't giving feedback, these days I'll see if I can update it and see what can be improved!

blazoncek · 2023-09-28T11:13:59Z

Hi @ajotanc,

When you'll be updating this PR/tool, please add documentation in a similar way as was done for PixelArt Converter.
https://kno.wled.ge/features/pixel-art-converter/

ajotanc · 2023-09-28T11:43:19Z

Hi @ajotanc,

When you'll be updating this PR/tool, please add documentation in a similar way as was done for PixelArt Converter. https://kno.wled.ge/features/pixel-art-converter/

How do I deal with this documentation issue? I'll go back and look at it today. I believe I already uploaded an update today

blazoncek · 2023-09-28T11:47:52Z

How do I deal with this documentation issue? I'll go back and look at it today. I believe I already uploaded an update today

Fork WLED-Docs, add description in relevant .md files nad then make a PR. Similar process as in main WLED repo.
@wled-faq or @dosipod or @scottrbailey may be able to help you better.

Topic 1, 2 I made the change, took it off the website and put it in the Preset section under the +Preset, +Playlist buttons, it was in a good location. Topic 3, 4 It reloads because it needs the updated information so that it can create the preset correctly with all the information generated from the selected image. Topic 5 The change has already been made, it just hasn't gone up yet, it's default upload Topic 6, 7 Fixed

It was missing to upload this file in the commit. - PXMagic is enabled by default in the Preset tab, and can be disabled in Settings, UI session

blazoncek · 2023-10-15T20:03:34Z

My suggestion would be to move the button in color/palette tab. Like so:

Or on the other side next to +.

This reverts commit ba49da7.

dosipod · 2023-10-16T07:02:24Z

Hi @ajotanc,
When you'll be updating this PR/tool, please add documentation in a similar way as was done for PixelArt Converter. https://kno.wled.ge/features/pixel-art-converter/

How do I deal with this documentation issue? I'll go back and look at it today. I believe I already uploaded an update today
@ajotanc
Hey , It is very simple to do docs as you already made a video which i prefer but KB is mostly done with pictures , i have made a draft from the doc of existing tool . located here https://github.com/dosipod/WLED-Docs/blob/master/docs/features/pxmagic.md . once your PR is finalize then we can finalize the doc for it along with pics ,video demo .etc . Does not harm to actually have the same instruction listed on both your site and KB . In all cases an instruction on your github page might be enough and more practical for faster updates as this is basically an external tool but that would mean you have to maintain an updated docs once you do a change as we have no write access to your repo to modify that

ajotanc · 2023-10-16T11:12:25Z

Hi @ajotanc,
When you'll be updating this PR/tool, please add documentation in a similar way as was done for PixelArt Converter. https://kno.wled.ge/features/pixel-art-converter/

How do I deal with this documentation issue? I'll go back and look at it today. I believe I already uploaded an update today
@ajotanc
Hey , It is very simple to do docs as you already made a video which i prefer but KB is mostly done with pictures , i have made a draft from the doc of existing tool . located here https://github.com/dosipod/WLED-Docs/blob/master/docs/features/pxmagic.md . once your PR is finalize then we can finalize the doc for it along with pics ,video demo .etc . Does not harm to actually have the same instruction listed on both your site and KB . In all cases an instruction on your github page might be enough and more practical for faster updates as this is basically an external tool but that would mean you have to maintain an updated docs once you do a change as we have no write access to your repo to modify that

I will do this by completing what was done, I ended up not touching it yet to make it functional first in the WLED UI and thus make it complete.

But I took a look at what was done and it was super interesting, I think I just need to complete it, it's very interesting how it was done.

I added the possibility of using the tooltip on buttons (.btn) with the span inside the button; Adjusted the tooltip css to center 100% in the middle Some cleaning and correction of sele

Since PXM will not open internally but on another page from the button, I decided to add the logo again if it's not a problem of course.. Just so I don't run out of information

ajotanc and others added 12 commits June 13, 2023 19:42

Adding Pixel Magic Tool to WLED

b4f08fa

Revert "Adding Pixel Magic Tool to WLED"

61637f1

This reverts commit b4f08fa.

Adding Pixel Magic Tool to WLED

68860ae

Corrections and performance improvements

c361c34

Remove IE compatibility tag

ea96412

(saves a few bytes and IE10 is over 10 years old and unsupported) Correct HTML language attribute (Chrome would show a popup asking to translate from Portugese)

Corrections and performance improvements

0d28728

Enable pxmagic by default

94aeb19

Updating pxmagic and inserting it in the WLED UI with option to enabl…

44197d9

…e and disable.

Revert "Updating pxmagic and inserting it in the WLED UI with option …

e010e67

…to enable and disable." This reverts commit 44197d9.

Updating pxmagic and WLED UI

aec0bc5

Merge remote-tracking branch 'upstream/main' into pxmagic

cd6b3d7

Correction

37dc17a

softhack007 added this to the 0.14.2 candidate milestone Sep 5, 2023

blazoncek marked this pull request as draft September 28, 2023 11:17

ajotanc added 4 commits September 28, 2023 09:09

Corrections

acfc166

Merge remote-tracking branch 'upstream/main' into pxmagic

f2d00e6

Corrections

4194e66

It was missing to upload this file in the commit. - PXMagic is enabled by default in the Preset tab, and can be disabled in Settings, UI session

ajotanc added 3 commits October 16, 2023 01:10

Modifications

ba49da7

Revert "Modifications"

7a4e0cc

This reverts commit ba49da7.

Modifications

3581f4c

ajotanc marked this pull request as ready for review October 16, 2023 04:19

Merge branch 'main' into pxmagic

c43b4f9

ajotanc added 4 commits October 16, 2023 19:09

Corrections made, added in a very accessible place

5da33af

I added the possibility of using the tooltip on buttons (.btn) with the span inside the button; Adjusted the tooltip css to center 100% in the middle Some cleaning and correction of sele

Correction related to enabling and disabling PXM in the User Interface

c33c7eb

Some functionality improvements

b6f4396

Add brand

aca0104

Since PXM will not open internally but on another page from the button, I decided to add the logo again if it's not a problem of course.. Just so I don't run out of information

blazoncek changed the base branch from main to 0_14_1 October 21, 2023 17:48

blazoncek added 2 commits October 21, 2023 20:01

Fix gitignore.

0e20248

Revert changes.

5820792

blazoncek merged commit 107bb14 into Aircoookie:0_14_1 Oct 21, 2023
9 of 12 checks passed

blazoncek mentioned this pull request Jan 18, 2024

14.1 can't connect to router on 14.1 on ESP8266 Wemos D1 mini #3690

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating pxmagic and WLED UI #3296

Updating pxmagic and WLED UI #3296

ajotanc commented Jul 20, 2023

blazoncek commented Jul 22, 2023 •

edited

Loading

blazoncek commented Jul 31, 2023

blazoncek commented Aug 21, 2023

ajotanc commented Aug 22, 2023

blazoncek commented Sep 28, 2023

ajotanc commented Sep 28, 2023

blazoncek commented Sep 28, 2023

blazoncek commented Oct 15, 2023

dosipod commented Oct 16, 2023

ajotanc commented Oct 16, 2023

Updating pxmagic and WLED UI #3296

Updating pxmagic and WLED UI #3296

Conversation

ajotanc commented Jul 20, 2023

blazoncek commented Jul 22, 2023 • edited Loading

blazoncek commented Jul 31, 2023

blazoncek commented Aug 21, 2023

ajotanc commented Aug 22, 2023

blazoncek commented Sep 28, 2023

ajotanc commented Sep 28, 2023

blazoncek commented Sep 28, 2023

blazoncek commented Oct 15, 2023

dosipod commented Oct 16, 2023

ajotanc commented Oct 16, 2023

blazoncek commented Jul 22, 2023 •

edited

Loading