-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ES8388Source & ES7243 initialization. #3377
Fix ES8388Source & ES7243 initialization. #3377
Conversation
Update ES8388Source::initialize and ES7243::initialize method signatures to match I2SSource::initialize so that when initialize is called on a AudioSource pointer the child class's method is used.
IMO it should be the other way around. |
I agree with @blazoncek. The only place where this specific WLED/usermods/audioreactive/audio_reactive.h Lines 1164 to 1169 in 527e3d6
The two extra parameters were meant for SDA and SDL (I2C) but with the change to only use global I2C pins, these are not needed any more. |
…verriding methods.
Updated, but I was only able to test it with ES8388 and Generic I2S since that's all the hardware I have. |
I think this is also a problem @netmindz was facing when moving upstream code to MM. BTW Nobody seems to have ES7243 any more. Perhaps @FHeilmann? |
Move was actually in the other direction. Removal of I2C from source broke MM as I think the global I2C hadn't actually been merged into MM at that stage |
* debug messages added to different initializers * SPH0654::initialize() was having a wrong signature: uint8 instead of int8. C++ can be a real bastard ;-)
thanks for this PR :-) well spotted 👍 |
…ive-initialize-i2ssource-bugfix Fix ES8388Source & ES7243 initialization.
Update ES8388Source::initialize and ES7243::initialize method signatures to match I2SSource::initialize so that when initialize is called on a AudioSource pointer the child class's method is used.