Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 2D Configuration button by default #3484

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

w00000dy
Copy link
Contributor

The problem was that when the settings page loaded, the "2D Configuration" button appeared a few milliseconds later than the other buttons. This meant that sometimes you would accidentally make incorrect input. If you were fast and wanted to press a button quickly, the button would appear just before you pressed it, causing the rest of the buttons to move as well, and you would press the wrong button.

@w00000dy w00000dy marked this pull request as draft October 25, 2023 16:08
@w00000dy w00000dy marked this pull request as ready for review October 25, 2023 16:44
@blazoncek
Copy link
Collaborator

I prefer it the other way around: showing an option when it is present, not hiding an option when it is not present.
If you understand what I mean. 😁

@w00000dy
Copy link
Contributor Author

Actually, I'm on your side, but in this case I would do it this way because of the following reasons:

  1. We have two macros: WLED_DISABLE_2D and WLED_ENABLE_DMX. For me it is more logical when you disable something that it then gets hidden and when you enable something that it then gets visible. And since 2D is enabled by default, I would leave it visible by default.

  2. It doesn't look so nice if the settings page has to build up first and is not completely loaded immediately.

  3. The much more important reason is that if you click through the menu too fast, you may misclick more easily, since button is displayed only after about 20ms. For example, if you want to go to Time & Updates and you need 15ms to place the mouse cursor on the Time & Updates button, then just before you left-click, 2D Configuration may appear and you may misclick. I think on mobile devices with touch display it is even more likely to misclick.

@blazoncek blazoncek merged commit ccc56d4 into Aircoookie:0_14_1 Oct 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants