Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.14.1-beta #3529

Merged
merged 101 commits into from
Dec 18, 2023
Merged

0.14.1-beta #3529

merged 101 commits into from
Dec 18, 2023

Conversation

blazoncek
Copy link
Collaborator

Bugfixes & minor new features

ajotanc and others added 30 commits June 13, 2023 19:42
(saves a few bytes and IE10 is over 10 years old and unsupported)
Correct HTML language attribute
(Chrome would show a popup asking to translate from Portugese)
Topic 1, 2
I made the change, took it off the website and put it in the Preset section under the +Preset, +Playlist buttons, it was in a good location.

Topic 3, 4
It reloads because it needs the updated information so that it can create the preset correctly with all the information generated from the selected image.

Topic 5
The change has already been made, it just hasn't gone up yet, it's default upload

Topic 6, 7
Fixed
It was missing to upload this file in the commit.

- PXMagic is enabled by default in the Preset tab, and can be disabled in Settings, UI session
…(loud fans) like delta fans to cap at a maximum percentage to keep noise down.
Mode blending option
Optimisations
added the max fan pct to the PWM-Fan usermod.
Usermod SSDR - allow configurable leading zero
This reverts commit ba49da7.
@blazoncek blazoncek linked an issue Nov 28, 2023 that may be closed by this pull request
1 task
@harueg
Copy link

harueg commented Nov 28, 2023

Thank you !

blazoncek and others added 9 commits November 29, 2023 13:42
Fix for UCS8904 hasWhite().
I've found a code spellchecker, so this is what can be corrected easily. Changes are only affecting comments, readme and a few user-visible strings. So no functional impact expected.
if you can spell Fahrenheit, you can't spell Celsius. And vice versa :-)
obuf is reset to nullptr in some cases
@blazoncek
Copy link
Collaborator Author

blazoncek commented Dec 14, 2023

@softhack007 apart from cosmetic changes (which are welcome) do you think 0.14.1 could be released as is?
EDIT: at least as beta?

@softhack007
Copy link
Collaborator

softhack007 commented Dec 14, 2023

@softhack007 apart from cosmetic changes (which are welcome) do you think 0.14.1 could be released as is? EDIT: at least as beta?

@blazoncek I think you are right. 0.14.1 has collected many bugfixes. Let's scan over PRs tagged as "0.14.1 candidate", and see what can be merged without danger of breaking other stuff. For example, I'd like to make this small update for pico boards, see my proposal in #3573.

Then we can go for releasing 0.14.1 after the weekend. What do you think? Anything left on your toDo list for 0.14.1?

Edit: it means I'm in favour of releasing 0.14.1 without going through a beta. If people have new problems, we can push out 0.14.2 maybe end of January to fix such problems.

@blazoncek
Copy link
Collaborator Author

I have moved everything, except nodemcuv2, esp8266_2m, esp01_1m_full, esp32dev, esp32_eth, esp32dev_audioreactive, lolin_s2_mini, esp32c3dev, esp32s3dev_8MB out of platformio.ini (as an experiment) locally.
It feels so refreshed!

I do not want any PR into 0.14.1. Not even @WoodyLetsCode HTML optimisation. Let 0.14.1 be a bugfix release and then concentrate on 0.15 as a way forward.

@softhack007
Copy link
Collaborator

It feels so refreshed!

Agreed, so we don't touch platformIO.ini for 0.14.1.

I do not want any PR into 0.14.1. Not even @WoodyLetsCode HTML optimisation. Let 0.14.1 be a bugfix release and then concentrate on 0.15 as a way forward.

👍 right, let's do it like that.

PHST abbreviation added for clarity.
According to the technical manual, GPIO 16 + 17 are used for onboard flash, so cannot be used by WLED.

example buildenv:

[env:esp32_pico]
extends = env:esp32dev_qio80
board = pico32
refreshing all UI files
Copy link
Collaborator

@softhack007 softhack007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, i've managed to do a fast walk through the changes.
Only very minor comments and a few questions. The only part that should get corrected is the new LDR usermod - it uses pins for analogread, but does not register them in pinmanager. Also it seems to not disable itself when set to "disable".

For everything else, I think we are ready to go 👍

wled00/FX.cpp Show resolved Hide resolved
wled00/FX.cpp Show resolved Hide resolved
wled00/FX.h Show resolved Hide resolved
usermods/LDR_Dusk_Dawn_v2/usermod_LDR_Dusk_Dawn_v2.h Outdated Show resolved Hide resolved
@blazoncek
Copy link
Collaborator Author

@Aircoookie please get back to us. 😉

@softhack007 if @Aircoookie does not respond in a couple of days I think we can merge this and release beta/GM version on Monday/Tuesday and if all goes well release 0.14.1 on Saturday/Sunday just before Christmas. I think it is safe as there were mostly bugfixes included.

@softhack007 softhack007 changed the title 0.14.1-b1 0.14.1-beta Dec 16, 2023
@blazoncek
Copy link
Collaborator Author

@softhack007 I am merging this now. Can you prepare a release?

@blazoncek blazoncek merged commit 7642c5a into main Dec 18, 2023
24 checks passed
@softhack007
Copy link
Collaborator

softhack007 commented Dec 19, 2023

@blazoncek I can make the gh "golden master" pre-release tomorrow - just need to come up with a few intro words - as you already put all details into changelog. Tomorrow, because my brains want to sleep after a long day now ;-)
Cheers 👋

@blazoncek
Copy link
Collaborator Author

I've already saved release draft. It only requires binaries and publish button.

@softhack007
Copy link
Collaborator

softhack007 commented Dec 19, 2023

👍 I'll quickly cross read and then push it tomorrow morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playlist transition time being ignored/reset TM1814: Solid Effect no longer works with the release of 0.14.0