-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fw1906 Support (based on 0-15) #3810
Conversation
When you have successfully tested my updates and confirm that it is working, we can proceed merging. |
I'm trying to compile, but it fails : `wled00/wled_server.cpp:3:10: fatal error: html_ui.h: No such file or directory
#include "html_ui.h" Environment Status Duration lolin_s2_mini FAILED 00:00:02.675` Is there something I miss ? Thank you for your help, I would appreciate to test the FW1906 support. |
You need to build the encoded HTML first, heres how I build:
|
Oh, so cool.... compiled and writen into my Wemos S2 Mini !!! Thous commands are not listed in the Compile wiki... I couldn't guess it. Thank you @deece |
No FW1906 listed for the Led Output settings... Is it normal? or hidden ? version installed : WLED 0.15.0-b1 (build 2403100) |
Please show the output of |
In fact, I was still on Aircoookie git, 0_15 branch.
|
I just pushed a fix for that |
Perfect, I could compile and install again. FW1906 is now in the list. |
@blazoncek It kinda works, RGB is fine, but when I switch to the white channel, both WW & CW are lit, and the controls don't shift between them. |
Next time pull upstream. The fix is incorrect and will break future updates.
Please elaborate on this. Switch? How? |
Sorry, on the Solid effect, I turned the Value/Brightness slider down to 0, then turned the White Channel slider to the maximum. The expected behaviour when manipulating the White Balance slider is to shift the output between the WW & CW emitters, but they instead remain constant regardless of position. |
This enable it to other bus types.
Do not force push! |
Hello @deece, I'm actually trying to drive my FW1906 RGB+CTT strip led. Considering that first cursor is RGB channel brightness, second cursor is White channel brightness, third cursor is White balance. 1/ Only RGB (White Channel brightness at 0) 2/ Only White (RGB channel brigtness at 0) |
@
@mathojojo Could you please |
@deece the issue might be in this statement: Try rewriting it into: PolyBus::setPixelColor(_busPtr, _iType, pix, c, co, ((uint16_t)cctCW<<8) | (uint16_t)cctWW); |
Thanks, unfortunately, that didn't work. I added some debug to calculateCCT:
Here are the values when varying the white balance slider:
Max warm white:
Max Cool white:
I then enabled "Calculate CCT from RGB" in the LED settings, and it behaves as expected. Should it be forced on for RGBCCT devices? |
No. That means that CCT value is not taken from the UI. |
I think I found the issue. If you are using ESP32 disable double buffer and test again. |
I will test again as soon as the issue is patched (double buffer disabled) :) And i was curious about versions of NeoPixelBus :
What version of NPB is wled FW1906_0_15 relying on ? And what is RGBwww ? Thank you for the hard work, it's cool to see the live progress here ! |
Patched? There is no need to patch to test. |
@blazoncek Good sleuthing. I disabled "Use global LED buffer:" in the config, and the strip behaves as expected, with "Calculate CCT from RGB" disabled. |
From the original PR, the required patch is Makuna/NeoPixelBus@978b62f |
The problem is that in line 1218 of If you'd move the offending line after the |
In short: until double buffer can handle CCT this will remain in POC state (draft). |
ok, would you like me to work on that? |
If you feel comfortable, go ahead. I think it shouldn't be too difficult, but I may be wrong as it's been a while since I did buses. |
Yes, it's easy. I already have it done. |
It is a bit more involved than I first thought. |
I'm happy to test, just push or point me at a repo :) |
While I push modifications later in the evening, try this until then:
|
Hello, I just removed all my WLED directory, and git cloned deece's fork again (fw1906_0_15). But I don't see any difference with my previuous tests. RGB is OK, but not CCT. Moving the white channel cursor makes the leds brightness increase or decrease as expected. But moving the White Balance cursor doesn't have any effect. Both White Leds are always staying at 50%-50%. Or should I have switched to another branch ? |
- additional fix in hasWhite() & setCCT() & hasCCT()
@deece here you go. It took a bit more time. |
Ok, don't pay any attention to my last message.... I recloned again, but this time using And now, I can confirm that WW and CW seems to behave as expected. |
@blazoncek With the latest changes, if the white balance slider is altered, no change is visible on the strip, and the slider jumps back to the middle when the mouse button is released. This should be observable without a strip connected ;) |
Slider fixed. |
Just here to says that I'm very grateful for your work. My entire living room is equipped with this type of strip and it will be only for you if I will be able to use it properly. Long live WLED and its contributors! |
You can show support/appreciation by buying me a beer. 😉 |
Awesome, I've tested that and confirmed it works as expected, both with & without "global LED buffer". I've verified that RGB effects work independently of the white channel, so an effect that leaves some LEDs off still shows the white channel at it's selected colour temperature. Is there anything else you would like me to test? |
@Robert-github-com do you have anything to add or can you test as well? @deece you could add PWM CCT and test it alongside FW1906. |
Ha! I just ordered these a couple of days ago: https://a.aliexpress.com/_mLlqKbc It will take a couple of weeks though. I think I have an H801 controller floating around somewhere... |
@blazoncek I put a tester together on a breadboard and confirmed that PWM RGB+CCT, as well as RGBW works as expected, both with & without "global LED buffer". |
This PR contains the work within #3298 by @Robert-github-com
All the hard work has been done by him, I have just rebased and squashed it.
The work-in-progress commits have been squashed to make the changes easier to review, and the patchset has been rebased on top of 0-15.
I have successfully built this and confirmed that it can drive the LED strip, and that both RGB animations & CCT control works.