Draft: AsyncWebServer queue support #4119
Open
+35
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ESPAsyncWebserver and AsyncTCP dependency calls to the queue supporting branches.
Enable the new concurrent request and queue size limit features of AsyncWebServer. This should improve the handling of burst traffic or many clients, and significantly reduce the likelihood of OOM crashes due to HTTP requests.
This can be helpful for debugging web handler related issues.
Use the web server's queuing mechanism to call us back later.
No locking contention, but a much larger target
Update based on empirical data on an ESP32-WROVER, -WROOM, and -S2.
|
When I get home from vacation I'll give it a spin. |
My turn to forget the 'v'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add queuing capabilities to AsyncWebServer, allowing deferred request handling to spread out memory load, generating 503 responses when the device is overloaded, and effectively preventing the web API from causing OOM crashes.
This PR should be considered beta quality; the upstream branch has not yet been merged, pending wider testing. I've tested it as thoroughly as I can, given my limited stable of devices, and I have run out of ways to make them hang or crash with
curl. Please consider merging this branch with your work-in-progress code to try it in more devices and under different load conditions.