Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling troublesome unit test. #298

Closed
wants to merge 3 commits into from

Conversation

jeffctown
Copy link
Collaborator

@jeffctown jeffctown commented Mar 6, 2019

  • Disabling troublesome unit test.
  • Updating Readme with known issue.

Checklist

  • I've checked that all new and existing tests pass
  • I've updated the documentation if necessary
  • I've added an entry in the CHANGELOG to credit myself

Motivation and Context

Updates according to #230 .

@jeffctown jeffctown closed this Mar 6, 2019
@jeffctown jeffctown deleted the feature/DisablingTroublesomeUnitTest branch March 6, 2019 12:21
@AliSoftware
Copy link
Owner

Just dequeuing my notifications rn, I see you have decided to not merge this but just FYI if we were to fail to find a solution and decided to indeed disable the test for CI to be more reliable, I'd at least do it the same way I did for timing tests: wrap them in a big #if condition which would default to true, and make it false on CI by injecting the build setting during rake invocation on CI (see DISABLE_TIMING_TESTS or whatever I called that #if)

@AliSoftware AliSoftware mentioned this pull request Mar 6, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants