Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary gtest install by system package manager #852

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

JasonMarechal25
Copy link
Contributor

No description provided.

@a-zakir
Copy link
Contributor

a-zakir commented Jun 20, 2024

a lot changes that don"t match the PR objective,

@JasonMarechal25 JasonMarechal25 changed the base branch from ci/antares_deps_vcpkg to develop June 20, 2024 15:05
@JasonMarechal25
Copy link
Contributor Author

a lot changes that don"t match the PR objective,

I had based this branch on another one (B) but forgot to set the base branch for the PR as B. Following your comment and given the size of the change I have now based the branch on develop for clarity and simplicity

@JasonMarechal25 JasonMarechal25 changed the title Remove unnecessary gtest install from package Remove unnecessary gtest install by system package Jun 20, 2024
@JasonMarechal25 JasonMarechal25 changed the title Remove unnecessary gtest install by system package Remove unnecessary gtest install by system package manager Jun 20, 2024
Copy link

sonarcloud bot commented Jul 2, 2024

@JasonMarechal25 JasonMarechal25 marked this pull request as draft August 19, 2024 08:52
Copy link

sonarcloud bot commented Aug 19, 2024

@JasonMarechal25 JasonMarechal25 marked this pull request as ready for review August 19, 2024 11:15
@JasonMarechal25 JasonMarechal25 requested a review from a team August 19, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants