Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugreport - WUMA Restriction System Doesn't like MSync rank assignment style #87

Open
Bryantdl7 opened this issue Nov 17, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Bryantdl7
Copy link

Bryantdl7 commented Nov 17, 2023

Description
When a user loads into a server where they are not cached in the users.txt file of that server, they will have the appropriate rank visibly, however, some addons such as the widely used restriction system WUMA will think the user is the guest role, and assign rights as such.

Reproduction

  1. Give a user a privileged rank with no restrictions
  2. Restrict something easy to reproduce e.g. a prop, or a weapon, like the hl2 revolver
  3. Shut off the server
  4. Delete the users.txt
  5. Reboot server
  6. Have user rejoin
  7. User will have the proper rank, but not be allowed to spawn the hl2 357, etc.

Workaround

  1. Set users ranks using ulx adduserid and then they are cached fully in ulib

Error Messages
N/A

This very small use case bug is caused by the way that MSync assigns ranks to users when they load in, more of a bandaid would be to use the function RunConsoleCommand("ulx", "adduserid" , ply:SteamID() , newRank)

Many servers already use auto promote addons which use the above logic, and this makes sure everyone fully has their rank working

@Bryantdl7 Bryantdl7 added the bug Something isn't working label Nov 17, 2023
@ApertureDevelopment
Copy link
Member

ApertureDevelopment commented Nov 17, 2023

I'd prefer an approach which does not require running ulx commands. The alternative approach would be to use ucl functions

ULib.ucl.addUser

I am gonna take a look when I am back home and implement the fix

For reference: https://github.com/TeamUlysses/ulx/blob/master/lua/ulx/modules/sh/user.lua#L51

ApertureDevelopment added a commit that referenced this issue Nov 17, 2023
This fix needs verification
@ApertureDevelopment ApertureDevelopment self-assigned this Nov 17, 2023
@ApertureDevelopment ApertureDevelopment added this to the v1.5.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants