Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Fw update over FoE #56

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Conversation

XzuluX
Copy link
Contributor

@XzuluX XzuluX commented Feb 17, 2021

Implemented firmware update for slave device.

Enhanced wrapper with functionality to set mailbox configuration for specific slave in order to download firmware file over FoE. Firmware update functionality has been verified with Beckoff Slave EL3021.
Implemented also functions to trigger slave state transition to new state and read current slave state.

@Apollo3zehn
Copy link
Owner

Thanks for that useful PR. However, could you please raise it against the dev branch? Thanks :)

@XzuluX
Copy link
Contributor Author

XzuluX commented Feb 17, 2021

I rebased it to dev branch, so it's on the top of dev. Do you mean that with raise against dev?

@Apollo3zehn
Copy link
Owner

No, sorry I mean this
grafik

You want to merge into master, but I would prefer if you could change it to dev. Thank you!

@XzuluX XzuluX changed the base branch from master to dev February 17, 2021 16:57
Copy link
Owner

@Apollo3zehn Apollo3zehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, looks very good. There is only one thing I think should be changed: You have renamed RequestOpState to RequestCommonState. But RequestOpState is specific to the OP state because it contains

ecx_send_processdata(context);
ecx_receive_processdata(context, EC_TIMEOUTRET);

I think we could instead rename the CheckSafeOpState method which does exactly what I think you indent with RequestCommonState and let RequestOpState untouched.

@Apollo3zehn
Copy link
Owner

Sorry, I was wrong, CheckSafeOpState is really just a check. Maybe we can instead change the code of RequestCommonState to skip the processdata methods for states other than "OP".

@XzuluX
Copy link
Contributor Author

XzuluX commented Feb 24, 2021

Thank's for reviewing my PR! I changed RequestCommonState and now the processdata methods are only performed if current state is OP.

@Apollo3zehn Apollo3zehn merged commit 613baa1 into Apollo3zehn:dev Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants