Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build patched libfuse3 to find more fusermount binaries #11

Merged
merged 12 commits into from
Aug 22, 2023

Conversation

probonopd
Copy link
Member

@probonopd probonopd commented Jul 1, 2023

Build static libfuse3 with a patch to find fusermount in the following way:

  1. Absolute path contained in the FUSERMOUNT_PROG environment variable
  2. fusermount3 on the $PATH
  3. fusermount on the $PATH (known to work for our purposes)
  4. fusermount4...99 on the $PATH(speculative attempt at future-proofing; but better than not trying at all)

Closes #10

@probonopd
Copy link
Member Author

probonopd commented Jul 1, 2023

Maybe we should search for the binaries in question on FUSERMOUNT_DIR instead on the $PATH for security reasons?

The reason I used $PATH is that we can never know where (exotic) distributions will put binaries a few years down the road.

@TheAssassin
Copy link
Member

I have not had time to review your patch. At a first glance, there is a lot to discuss here, especially regarding software security. We should never worsen libfuse's.

@probonopd probonopd changed the title Build static libfuse3 Build patched libfuse3 to find more fusermount binaries Jul 2, 2023
This seems to determine where the compiled libfuse searches for fusermount
@probonopd
Copy link
Member Author

probonopd commented Jul 2, 2023

Successfully tested on AlmaLinux 9.1 (Lime Lynx) which comes with /usr/bin/fusermount but not with fusermount3:

./appimagetool-x86_64.AppImage --appimage-extract
unzip artifacts.zip # Use runtime from this PR
VERSION=1 ./squashfs-root/AppRun --runtime-file ./runtime-x86_64 ./squashfs-root/
./appimagetool-1-x86_64.AppImage # WORKS

@probonopd probonopd merged commit c9553b0 into main Aug 22, 2023
4 checks passed
@Bqleine Bqleine mentioned this pull request Jul 3, 2024
@TheAssassin TheAssassin deleted the build-patched-libfuse3 branch July 3, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that this works with fusermount, fusermount3, ... fusermountN
2 participants