Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to register AppImage With Additional Actions to the IntegrationManager #138

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

azubieta
Copy link
Contributor

@azubieta azubieta commented Jul 31, 2019

Custom applications actions are added by AppImageLauncher and AppImageServices after the desktop file is created. This allows to add such actions when the desktop file is created.

Implements #137

Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be more comments.

What would be useful as well: I'd like to be able to add more regular keys to the main section. That's not supported as of now, is it?

@azubieta
Copy link
Contributor Author

azubieta commented Aug 5, 2019

What would be useful as well: I'd like to be able to add more regular keys to the main section. That's not supported as of now, is it?

No, it's not supported right now. Would you mind to present an use case where such additional keys will not be the ones added by the libappimage registerApplication method?

@TheAssassin
Copy link
Member

No, it's not supported right now. Would you mind to present an use case where such additional keys will not be the ones added by the libappimage registerApplication method?

For example when writing the version of AppImageLauncher into a desktop file, which can be useful for debugging, or some hashes that have a meaning to AppImageLauncher (in the future I plan to add some features that require this kind of stuff).

@azubieta
Copy link
Contributor Author

azubieta commented Aug 5, 2019

Those are very AIL specific things but seems reasonable to be able to add the capability of adding custom keys.

what about:

void registerAppImage(const core::AppImage& appImage,
                                        std::unordered_map<std::string, std::string> additionalEntries = {},
                                        std::unordered_map<std::string, std::string> additionalApplicationActions  = {}) const;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants