Fix libappimage_static #99
Conversation
|
If you still want to merge this, you need to fix the PR. |
azubieta
force-pushed
the
fix_libappimage_static_target
branch
from
fd5a485
to
156816a
Compare
|
Reference #76 Ideally, a binary with the lowest amount of dependencies must be provided the libappimage user. But, due to the large range of possible configurations keeping the track and bundling (in some cases it would be a bad idea do bundle other static libraries) of each dependency turns into a complex task. The current proposal left the dependencies management to the libappimage user so they will be responsible for resolving all of them (including libsquashfuse). |
azubieta
force-pushed
the
fix_libappimage_static_target
branch
from
156816a
to
a520623
Compare
|
why this was closed? |
|
You wrote
in the PR... |
|
My bad, that pr had nothing to do with this. Reference updated |
| set_property(TARGET libappimage PROPERTY VERSION ${libappimage_VERSION}) | ||
| set_property(TARGET libappimage PROPERTY SOVERSION ${libappimage_SOVERSION}) | ||
| # install libappimage | ||
| install( |
There was a problem hiding this comment.
I somewhere read that using PUBLIC_HEADER like this is actually wrong. Is there any reason you use that property? Are there alternative ways? (IIRC, you introduced that years ago, and I was always curious.)
There was a problem hiding this comment.
You are right, using PUBLIC_HEADER in Unix system is wrong, that property only has a real effect on MacOS.
| add_executable(client_app main.c) | ||
| target_link_libraries(client_app libappimage) | ||
|
|
||
| add_executable(client_app_static_linked main.c) |
There was a problem hiding this comment.
The "test" here is to check if linking works? You should document that somewhere, e.g., above this line.
Install and export the libappimage_static target.
Move the
appimage_registered_desktop_file_pathfunction intolibappimmage.cppand use C++ on it.