fix synthetic accessor lint warnings and remove from baseline

Arian04 · Jun 30, 2024 · 872a2b6 · 872a2b6
1 parent 0d0d08f
commit 872a2b6
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 72 deletions.
diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml
@@ -155,50 +155,6 @@
             column="13"/>
     </issue>
 
-    <issue
-        id="SyntheticAccessor"
-        message="Access to `private` method `HelpPage` of class `HelpScreenKt` requires synthetic accessor"
-        errorLine1="        HelpPage()"
-        errorLine2="        ~~~~~~~~">
-        <location
-            file="src/main/java/me/arianb/usb_hid_client/HelpScreen.kt"
-            line="39"
-            column="9"/>
-    </issue>
-
-    <issue
-        id="SyntheticAccessor"
-        message="Access to `private` method `InfoPage` of class `InfoScreenKt` requires synthetic accessor"
-        errorLine1="        InfoPage()"
-        errorLine2="        ~~~~~~~~">
-        <location
-            file="src/main/java/me/arianb/usb_hid_client/InfoScreen.kt"
-            line="28"
-            column="9"/>
-    </issue>
-
-    <issue
-        id="SyntheticAccessor"
-        message="Access to `private` method `MainPage` of class `MainScreenKt` requires synthetic accessor"
-        errorLine1="        MainPage()"
-        errorLine2="        ~~~~~~~~">
-        <location
-            file="src/main/java/me/arianb/usb_hid_client/MainScreen.kt"
-            line="45"
-            column="9"/>
-    </issue>
-
-    <issue
-        id="SyntheticAccessor"
-        message="Access to `private` method `OnboardingPage` of class `OnboardingScreenKt` requires synthetic accessor"
-        errorLine1="        OnboardingPage()"
-        errorLine2="        ~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/me/arianb/usb_hid_client/OnboardingScreen.kt"
-            line="27"
-            column="9"/>
-    </issue>
-
     <issue
         id="SyntheticAccessor"
         message="Access to `private` method `writeHIDReport` of class `Companion` requires synthetic accessor"
@@ -221,28 +177,6 @@
             column="9"/>
     </issue>
 
-    <issue
-        id="SyntheticAccessor"
-        message="Access to `private` method `SettingsPage` of class `SettingsScreenKt` requires synthetic accessor"
-        errorLine1="        SettingsPage()"
-        errorLine2="        ~~~~~~~~~~~~">
-        <location
-            file="src/main/java/me/arianb/usb_hid_client/settings/SettingsScreen.kt"
-            line="28"
-            column="9"/>
-    </issue>
-
-    <issue
-        id="SyntheticAccessor"
-        message="Access to `private` method `TroubleshootingPage` of class `TroubleshootingScreenKt` requires synthetic accessor"
-        errorLine1="        TroubleshootingPage()"
-        errorLine2="        ~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src/main/java/me/arianb/usb_hid_client/TroubleshootingScreen.kt"
-            line="53"
-            column="9"/>
-    </issue>
-
     <issue
         id="TypographyQuotes"
         message="Replace apostrophe (&apos;) with typographic apostrophe (’, &amp;#8217;) ?"

diff --git a/app/src/main/java/me/arianb/usb_hid_client/MainScreen.kt b/app/src/main/java/me/arianb/usb_hid_client/MainScreen.kt
@@ -50,7 +50,7 @@ class MainScreen : Screen {
 }
 
 @Composable
-private fun MainPage(mainViewModel: MainViewModel = viewModel()) {
+fun MainPage(mainViewModel: MainViewModel = viewModel()) {
     val rootStateHolder = RootStateHolder.getInstance()
     val rootState by rootStateHolder.uiState.collectAsState()
 

diff --git a/app/src/main/java/me/arianb/usb_hid_client/settings/SettingsScreen.kt b/app/src/main/java/me/arianb/usb_hid_client/settings/SettingsScreen.kt
@@ -24,7 +24,7 @@ class SettingsScreen : Screen {
 }
 
 @Composable
-private fun SettingsPage() {
+fun SettingsPage() {
     val padding = PaddingNormal
     val paddingModifier = Modifier.padding(horizontal = padding)
 

diff --git a/app/src/main/java/me/arianb/usb_hid_client/troubleshooting/TroubleshootingScreen.kt b/app/src/main/java/me/arianb/usb_hid_client/troubleshooting/TroubleshootingScreen.kt
@@ -56,7 +56,7 @@ class TroubleshootingScreen : Screen {
 }
 
 @Composable
-private fun TroubleshootingPage() {
+fun TroubleshootingPage() {
     BasicPage(
         topBar = { TroubleshootingTopBar() },
         scrollable = true

diff --git a/app/src/main/java/me/arianb/usb_hid_client/ui/standalone_screens/HelpScreen.kt b/app/src/main/java/me/arianb/usb_hid_client/ui/standalone_screens/HelpScreen.kt
@@ -42,7 +42,7 @@ class HelpScreen : Screen {
 }
 
 @Composable
-private fun HelpPage() {
+fun HelpPage() {
     val questionAnswerPairs = remember {
         arrayOf(
             Pair(R.string.help_faq_q1, R.string.help_faq_a1),

diff --git a/app/src/main/java/me/arianb/usb_hid_client/ui/standalone_screens/InfoScreen.kt b/app/src/main/java/me/arianb/usb_hid_client/ui/standalone_screens/InfoScreen.kt
@@ -31,7 +31,7 @@ class InfoScreen : Screen {
 }
 
 @Composable
-private fun InfoPage() {
+fun InfoPage() {
     BasicPage(
         topBar = { InfoTopBar() },
         horizontalAlignment = Alignment.CenterHorizontally,

diff --git a/app/src/main/java/me/arianb/usb_hid_client/ui/standalone_screens/OnboardingScreen.kt b/app/src/main/java/me/arianb/usb_hid_client/ui/standalone_screens/OnboardingScreen.kt
@@ -31,7 +31,7 @@ class OnboardingScreen : Screen {
 }
 
 @Composable
-private fun OnboardingPage() {
+fun OnboardingPage() {
     BasicPage(
         topBar = { OnboardingTopBar() },
         horizontalAlignment = Alignment.CenterHorizontally,