Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axes tracking #125

Closed
wants to merge 2 commits into from
Closed

Conversation

jordanruthe
Copy link
Contributor

Initial commit for #124

@grigi
Copy link
Contributor

grigi commented Mar 26, 2021

This is looking pretty good already 👍

This is for tracking moves, so it won't be able to track things like movement due to tilt adjustment, and will be less real for Delta printers.

I still like the ability to track E, that would be more accurate than the "filament used" in history tracking.
Could you make it work for multiple extruders as well please?

@jordanruthe jordanruthe marked this pull request as draft March 26, 2021 15:21
@Arksine
Copy link
Owner

Arksine commented Mar 26, 2021

I think its a good start, although I have a few early comments.

  • I don't think we should use gcode_move to derive the position. The toolhead position is the actual movement after transforms, so it should produce a more accurate result.
  • I think its worth exploring accumulating the position data in Klipper itself, which would make the above point moot. If we accumulate position data in Klipper we would just need to keep a running total across restarts. One nice thing about doing it in Klipper is that it would take care of homing for you (in fact homing movement would be included in the accumulated position).
  • I think we can put this in data_store.py. Its role is to track and store printer data, currently it tracks temperature data and gcode requests/responses. The data it stores isn't persistent, but there is no harm in tracking additional data that is.

FWIW, filament_used does track E. It excludes extrusion moves during a pause, which IMO makes it is the appropriate field to track print history.

The toolhead reports the extruder its using, so it is possible to track position per extruder. However if we move the accumulation to Klipper, E would be a total of all extruders. Accumulating position in Klipper would be far more accurate though. Moonraker receives updates ever 250 ms, which means that we will miss some data when a tool changes direction, so IMO it would be a good tradeoff.

@Arksine
Copy link
Owner

Arksine commented Sep 6, 2024

Since this is no longer being worked on I am closing it. Thanks.

@Arksine Arksine closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants