Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'png begin' and 'png end' #888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geekykayaker-anon
Copy link

I have an Ender3 V3 KE, with testing I've found that the display will show thumbnails if the text "png begin" is used, but NOT if the text "thumbnail begin" is used.

I've changed my slicer to use "png begin" but now moonraker can't detect the images...

Can we add support for both specification of png thumbnails?

@Arksine
Copy link
Owner

Arksine commented Sep 6, 2024

Hi. Moonraker supports the standard thumbnail format generated by PrusaSlicer and its derivatives. These thumbnails are already PNGs. It sounds like the software driving the display is deviating from the standard and should be corrected to use the normal thumbnail identifier for PNGs.

Further, Creality is not in compliance with Moonraker's GPLv3 license, along with other software in the Klipper ecosystem including Klipper itself. Until they correct this, my policy to to avoid adding support specific for Creality hardware and/or software to Moonraker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants