Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add candidacy un-bonding period #1281

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add candidacy un-bonding period #1281

wants to merge 7 commits into from
+500 −243

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Jun 26, 2024 •
edited
Loading

Pull Request Summary

https://forum.astar.network/t/collator-candidacy-un-bonding-period/7019

  • Modified call leave_intent to remove candidacy and start unbondig process.
  • Add call withdraw_bond to withdraw CandidacyBond after on next session.
  • Some refactoring/cleanup to make code more readable

@ermalkaleci
Copy link
Contributor Author

/bench astar-dev,shibuya-dev,shiden-dev pallet-collator-selection

@ermalkaleci ermalkaleci added the runtime This PR/Issue is related to the topic “runtime”. label Jun 26, 2024
@github-actions GitHub Actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9684829218.
Please wait for a while.
Branch: feat/improve-collator-selection
SHA: 2e6a63a

@ermalkaleci
Copy link
Contributor Author

/bench astar-dev,shibuya-dev,shiden-dev pallet-collator-selection

@github-actions GitHub Actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9684943439.
Please wait for a while.
Branch: feat/improve-collator-selection
SHA: 2e6a63a

@github-actions GitHub Actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9684943439.

@ermalkaleci ermalkaleci marked this pull request as ready for review July 1, 2024 13:45
Dinonard
Dinonard reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments.

pallets/collator-selection/src/lib.rs Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/tests.rs Outdated Show resolved Hide resolved
@ermalkaleci ermalkaleci requested a review from Dinonard July 2, 2024 16:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/inflation/src 83% 0% ✔
primitives/src 62% 0% ➖
chain-extensions/unified-accounts/src 0% 0% ❌
pallets/dapp-staking-v3/src 90% 0% ✔
pallets/astar-xcm-benchmarks/src/generic 100% 0% ✔
chain-extensions/types/assets/src 0% 0% ❌
precompiles/dispatch-lockdrop/src 86% 0% ✔
pallets/dapp-staking-v3/src/test 0% 0% ❌
pallets/dapp-staking-migration/src 0% 0% ❌
precompiles/xvm/src 75% 0% ➖
precompiles/sr25519/src 64% 0% ➖
pallets/astar-xcm-benchmarks/src/fungible 100% 0% ✔
pallets/xvm/src 54% 0% ➖
precompiles/unified-accounts/src 100% 0% ✔
pallets/xc-asset-config/src 64% 0% ➖
precompiles/substrate-ecdsa/src 74% 0% ➖
precompiles/dapp-staking-v3/src 90% 0% ✔
precompiles/assets-erc20/src 81% 0% ✔
pallets/collective-proxy/src 86% 0% ✔
pallets/dynamic-evm-base-fee/src 89% 0% ✔
pallets/price-aggregator/src 72% 0% ➖
chain-extensions/xvm/src 0% 0% ❌
pallets/static-price-provider/src 52% 0% ➖
pallets/astar-xcm-benchmarks/src 88% 0% ✔
primitives/src/xcm 64% 0% ➖
chain-extensions/types/xvm/src 0% 0% ❌
chain-extensions/types/unified-accounts/src 0% 0% ❌
pallets/collator-selection/src 92% 0% ✔
chain-extensions/pallet-assets/src 56% 0% ➖
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0% ❌
pallets/ethereum-checked/src 79% 0% ➖
precompiles/dapp-staking-v3/src/test 0% 0% ❌
pallets/oracle-benchmarks/src 0% 0% ❌
precompiles/xcm/src 73% 0% ➖
pallets/dapp-staking-v3/src/benchmarking 98% 0% ✔
pallets/unified-accounts/src 86% 0% ✔
Summary 77% (3704 / 4796) 0% (0 / 0) ➖

Minimum allowed line rate is 50%

Dinonard
Dinonard approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pallets/collator-selection/src/tests.rs
@@ -520,7 +520,7 @@ fn slash_mechanism_for_unbonding_candidates() {
initialize_to_block(20);
assert_eq!(CollatorSelection::candidates().len(), 1);
assert_eq!(SessionChangeBlock::get(), 20);
assert_eq!(CollatorSelection::last_authored_block(3), 0);
assert_eq!(LastAuthoredBlock::<Test>::contains_key(3), false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick for my soul - assert!(!....). 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it easier to read this way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok, I just commented for myself. I really dislike using assert_eq! for checking boolean values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

@shaunxw shaunxw Awaiting requested review from shaunxw

@ashutoshvarma ashutoshvarma Awaiting requested review from ashutoshvarma

@PierreOssun PierreOssun Awaiting requested review from PierreOssun

Assignees
No one assigned
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ermalkaleci @Dinonard