Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data_manager.py #30

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Update data_manager.py #30

merged 1 commit into from
Aug 21, 2023

Conversation

mughetto
Copy link
Collaborator

@mughetto mughetto commented Aug 21, 2023 •
edited
Loading

Using subscript with dict type throws error, the typing module provides typing.Dict for this.

This will fix build errors on read the docs.

@mughetto mughetto requested a review from dgeleta August 21, 2023 06:42
@mughetto mughetto marked this pull request as ready for review August 21, 2023 08:35
@mughetto mughetto merged commit 67db652 into main Aug 21, 2023
1 check passed
@mughetto mughetto deleted the mughetto-patch-dict-typehint branch August 21, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgeleta dgeleta dgeleta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mughetto @dgeleta