-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #4
base: dev
Are you sure you want to change the base?
Bugfix #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe once you change your PR it will retrigger the checks? Not sure why they failed in the first place
@@ -185,7 +185,7 @@ function autocomplete(inp, msg_arr, match_advanced=false) { | |||
a = document.createElement("DIV"); | |||
a.setAttribute("id", e.id + "autocomplete-list"); | |||
a.setAttribute("class", "autocomplete-items"); | |||
a.setAttribute("style",`width:${e.parentNode.offsetWidth}px`); | |||
a.setAttribute("style",`width:${e.parentNode.offsetWidth}px;position:relative;`); // Otherwise the div will end up way lower than the actual page. --FalB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Co-authored-by: Atisha Ribeiro <[email protected]>
@@ -185,7 +185,7 @@ function autocomplete(inp, msg_arr, match_advanced=false) { | |||
a = document.createElement("DIV"); | |||
a.setAttribute("id", e.id + "autocomplete-list"); | |||
a.setAttribute("class", "autocomplete-items"); | |||
a.setAttribute("style",`width:${e.parentNode.offsetWidth}px`); | |||
a.setAttribute("style",`width:${e.parentNode.offsetWidth}px;position:relative;`); // Otherwise the div will end up way lower than the actual page. --FalB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Style of the Autocomplete boxes was wrong. Also small optimization, no need to calculate stuff when you can just store the value in a variable.