Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update iNat /people/ link to use userId instead of userName #607

Closed
adam-collins opened this issue Jul 22, 2024 · 9 comments
Closed

update iNat /people/ link to use userId instead of userName #607

adam-collins opened this issue Jul 22, 2024 · 9 comments
Assignees
Milestone

Comments

@adam-collins
Copy link
Contributor

No description provided.

@adam-collins
Copy link
Contributor Author

@kylie-m
Copy link

kylie-m commented Jul 22, 2024

That's working for me, plus a few others I checked too

@peggynewman
Copy link

Probably need to also check that the inat query from a user profile is still working. I can't check because the link to inaturalist function doesn't work in test
https://aws-auth-test-2023.test.ala.org.au/userdetails/myprofile/
... but the links user details creates are
https://biocache.ala.org.au/occurrences/search?q=data_resource_uid:dr1411&fq=alau_user_id:peggydnew
and
https://biocache.ala.org.au/occurrences/search?q=data_resource_uid:dr1411%20OR%20data_resource_uid:dr364&fq=alau_user_id:peggydnew%20OR%20alau_user_id:%2219807%22
So I think that's fine ... my records look better in test as well

@sadeghim
Copy link
Member

Also, looking at the Original vs Processed, userID is not transferred to the processed column:
image

@adam-collins
Copy link
Contributor Author

@sadeghim to my understanding, userId is not processed by the pipelines so there will only be the field userId, not raw_userId and userId.

  1. If you want to change how pipelines works please create a new issue in biocache-service with the prefix pipelines - and describe the changes that are required.
  2. If you want to change a single field in /occurrences/compare/{uuid} please create an issue in biocache-service with details. Note that this service provides the data for "Original vs Processed" section, please raise an issue with details in biocache-service.

@sadeghim
Copy link
Member

@adam-collins I think, there is no need to change the logic of the pipelines. And that userId can stay as is since there is no real transformation to it.

@adam-collins
Copy link
Contributor Author

@peggynewman is that what you mean?

  1. user details links to biocache-service are working in production
  2. you cannot link a user test account to an inaturalist account
  3. user details URLs to biocache-service for inaturalist cannot be tested because you cannot link a user test account to an inaturalis account

Continuing with these assumptions

  • userName SOLR field is (was) suitable for use as links to iNaturalist of the form /people/{userName}.
  • This is now /people/{userId}. This informs me that it is likely that the userName contents changed or the /people/{user} address operation changed or it has never worked.
  • The links from userdetails (prod), that you provided, list the user filter as alau_user_id that is now an alias of userId.
  • The filter for dr1411 in the example is alau_user_id:peggydnew.
  • For iNaturalist data that we receive have the userId field contents change? If yes, how. If no, then userdetails will not need a change as long as userIds stored in userdetails has not changed. Given that production is still working this is likely the case.
  • The filter for dr364 in the example is alau_user_id:"19807". Given that this an ALA ID this URL is still correct unless biocollect changed the contents of the userId field. Please add a comment with details if that is the case.

@peggynewman
Copy link

Let me comment on these individually:

  1. user details links to biocache-service are working in production

yes, on the basis that the query is fq=alau_user_id:peggydnew

  1. you cannot link a user test account to an inaturalist account
  2. user details URLs to biocache-service for inaturalist cannot be tested because you cannot link a user test account to an inaturalis account

correct, inat does not have the test environment for OAUTH2, but you can just mangle the URL to see if it will work

userName SOLR field is (was) suitable for use as links to iNaturalist of the form /people/{userName}.
This is now /people/{userId}. This informs me that it is likely that the userName contents changed or the /people/{user} address operation changed or it has never worked.

Don't ever remember userName being working in production. I remember it not working in production and we had to fix it in the past few years. userName is full of spaces and can change, whereas userID is an iNaturalist user name that uniquely identifies them in the system and does not change. When this facility has not worked, people complain through the help desk so I am assuming that this is something that has recently gone wrong.

The links from userdetails (prod), that you provided, list the user filter as alau_user_id that is now an alias of userId.
The filter for dr1411 in the example is alau_user_id:peggydnew.

Yes, and that is my userId, not my userName. My userName is Peggy Newman and I can change that anytime to Datarey McDataface.

The filter for dr364 in the example is alau_user_id:"19807". Given that this an ALA ID this URL is still correct unless biocollect changed the contents of the userId field. Please add a comment with details if that is the case.

I thought it was weird that when we did this, we repurposed the alau_user_id field and as far as I understand, biocache knows that this field contains userIDs for both the ALA and iNaturalist.

@timhicks-ala
Copy link

(helpdesk note: raised in https://support.ehelp.edu.au/a/tickets/207168)

@nickdos nickdos closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants